FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Correct fscanf char field count

Browse source 
%<number>s as an fscanf format does not include the trailing NULL.
PATH_MAX does include the trailing NULL.

	PR 17453
	* readelf.c (process_program_headers): Correct fscanf format used
	for interpreter.
This commit is contained in:
Alan Modra 2014-10-14 13:30:57 +10:30
parent daf5e10e4c
commit 9495b2e66f
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
binutils/ChangeLog
View file

@ -1,3 +1,9 @@
2014-10-14 Alan Modra <amodra@gmail.com>
PR 17453
* readelf.c (process_program_headers): Correct fscanf format used
for interpreter.
2014-10-09 Jose E. Marchesi <jose.marchesi@oracle.com> 2014-10-09 Jose E. Marchesi <jose.marchesi@oracle.com>
* readelf.c (display_sparc_hwcaps2): New function. * readelf.c (display_sparc_hwcaps2): New function.

2
binutils/readelf.c
View file

@ -4394,7 +4394,7 @@ process_program_headers (FILE * file)
else else
{ {
char fmt [32]; char fmt [32];
int ret = snprintf (fmt, sizeof (fmt), "%%%ds", PATH_MAX); int ret = snprintf (fmt, sizeof (fmt), "%%%ds", PATH_MAX - 1);
if (ret >= (int) sizeof (fmt) || ret < 0) if (ret >= (int) sizeof (fmt) || ret < 0)
error (_("Internal error: failed to create format string to display program interpreter\n")); error (_("Internal error: failed to create format string to display program interpreter\n"));