FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "gdb/python: Avoid use after free in py-tui.c"

Browse source 
This reverts commit 982a38f60b.

I missed that the title being assigned too was a std::string, and so
there is no leak.
This commit is contained in:
Andrew Burgess 2020-06-05 21:07:58 +01:00
parent 982a38f60b
commit 940dace9cf
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2020-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
Revert commit 982a38f60b0.
* python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
2020-06-05 Andrew Burgess <andrew.burgess@embecosm.com> 2020-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
* python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to

2
gdb/python/py-tui.c
View file

@ -433,7 +433,7 @@ gdbpy_tui_set_title (PyObject *self, PyObject *newvalue, void *closure)
if (value == nullptr) if (value == nullptr)
return -1; return -1;
win->window->title = value.release (); win->window->title = value.get ();
return 0; return 0;
} }