FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify compile_module cleanup

Browse source 
This simplifies compile_module cleanup by removing the need to
explicitly free anything.  struct setup_sections_data is also cleaned
up a bit.

gdb/ChangeLog
2020-09-23  Tom Tromey  <tom@tromey.com>

	* compile/compile-object-run.c (do_module_cleanup)
	<~do_module_cleanup> :Remove.
	(do_module_cleanup): Update.
	* compile/compile-object-load.h (struct munmap_list): Add move
	assignment operator.
	<source_file>: Now a std::string.
	<munmap_list>: Rename.  No longer a pointer.
	* compile/compile-object-load.c (struct setup_sections_data): Add
	constructor.
	<setup_one_section>: Declare.
	<munmap_list>: Move earlier.
	<m_bfd>: New member.
	<m_last_size, m_last_section_first, m_last_prot,
	m_last_max_alignment>: Rename, add initializers where needed.
	(setup_sections_data::setup_one_section): Rename from
	setup_sections.  Update.
	(compile_object_load): Update.  Don't use bfd_map_over_sections.
This commit is contained in:
Tom Tromey 2020-09-23 09:32:54 -06:00
parent e616f60a6b
commit 92677124d9
4 changed files with 88 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

8
gdb/compile/compile-object-load.h
View file

@ -29,6 +29,8 @@ public:
DISABLE_COPY_AND_ASSIGN (munmap_list);
munmap_list &operator= (munmap_list &&) = default;
/* Add a region to the list. */
void add (CORE_ADDR addr, CORE_ADDR size);
@ -56,8 +58,8 @@ struct compile_module
/* objfile for the compiled module. */
struct objfile *objfile;
/* .c file OBJFILE was built from. It needs to be xfree-d. */
char *source_file;
/* .c file OBJFILE was built from. */
std::string source_file;
/* Inferior function GCC_FE_WRAPPER_FUNCTION. */
struct symbol *func_sym;
@ -81,7 +83,7 @@ struct compile_module
CORE_ADDR out_value_addr;
/* Track inferior memory reserved by inferior mmap. */
struct munmap_list *munmap_list_head;
struct munmap_list munmap_list;
};
/* A unique pointer for a compile_module. */