FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

x86/ELF: fix .tfloat output with hex input

Browse source 
The ELF psABI-s are quite clear here: On 32-bit the data type is 12
bytes long (with 2 bytes of trailing padding), while on 64-bit it is 16
bytes long (with 6 bytes of padding). Make hex_float() capable of
handling such padding.

Note that this brings the emitted data size of .dc.x / .dcb.x in line
also for non-ELF targets; so far they were different depending on input
format (dec vs hex).

Extend the existing x86 testcases.
This commit is contained in:
Jan Beulich 2021-08-11 08:31:41 +02:00
parent e74e2b4c33
commit 8f2200fe8e
5 changed files with 29 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
gas/read.c
View file

@ -4847,7 +4847,7 @@ parse_repeat_cons (expressionS *exp, unsigned int nbytes)
static int
hex_float (int float_type, char *bytes)
{
int length;
int length, pad = 0;
int i;
switch (float_type)
@ -4868,12 +4868,22 @@ hex_float (int float_type, char *bytes)
case 'x':
case 'X':
length = 12;
#ifdef X_PRECISION
length = X_PRECISION * sizeof (LITTLENUM_TYPE);
pad = X_PRECISION_PAD * sizeof (LITTLENUM_TYPE);
if (!length)
#endif
length = 12;
break;
case 'p':
case 'P':
length = 12;
#ifdef P_PRECISION
length = P_PRECISION * sizeof (LITTLENUM_TYPE);
pad = P_PRECISION_PAD * sizeof (LITTLENUM_TYPE);
if (!length)
#endif
length = 12;
break;
default:
@ -4926,7 +4936,9 @@ hex_float (int float_type, char *bytes)
memset (bytes, 0, length - i);
}
return length;
memset (bytes + length, 0, pad);
return length + pad;
}
/* float_cons()

3
gas/testsuite/gas/i386/fp-elf32.d
View file

@ -11,3 +11,6 @@ Contents of section .data:
0030 00000000 0000a044 01000000 0000a044 .*
0040 00000000 0000f03f 00000000 00000000 .*
0050 ffffffff ffffffff ffffffff cccccccc .*
0060 00000000 00000080 fe3f0000 00000000 .*
0070 00000080 fdbf0000 00000000 00000080 .*
0080 ff030000 aaaaaaaa aaaaaaaa aaaaaaaa .*

3
gas/testsuite/gas/i386/fp-elf64.d
View file

@ -11,3 +11,6 @@ Contents of section .data:
0030 00000000 0000a044 01000000 0000a044 .*
0040 00000000 0000f03f 00000000 00000000 .*
0050 ffffffff ffffffff ffffffff ffffffff .*
0060 00000000 00000080 fe3f0000 00000000 .*
0070 00000000 00000080 fdbf0000 00000000 .*
0080 00000000 00000080 ff030000 00000000 .*

2
gas/testsuite/gas/i386/fp.d
View file

@ -10,3 +10,5 @@ Contents of section .data:
0030 00000000 0000a044 01000000 0000a044 .*
0040 00000000 0000f03f 00000000 00000000 .*
0050 ffffffff ffffffff ffffcccc cccccccc .*
0060 00000000 00000080 fe3f0000 00000000 .*
0070 0080fdbf 00000000 00000080 ff03aaaa .*

5
gas/testsuite/gas/i386/fp.s
View file

@ -24,3 +24,8 @@
.ds.x 1, -1
.p2align 4,0xcc
.tfloat 0x:3ffe80
.dc.x 0x:bffd80
.dcb.x 1, 0x:03ff80
.p2align 4,0xaa