FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sim: igen: do not reindent literal semantics output

Browse source 
When generating semantics.c from .igen source files, indenting the code
makes it more readable, but confuses compiler diagnostics.  The latter
is a bit more important than the former, so bias towards that.

For example, with an introduced error, we can see w/gcc-13:

(before this change)
  CC       mn10300/semantics.o
../../../sim/mn10300/am33-2.igen: In function ‘semantic_dcpf_D1a’:
../../../sim/mn10300/am33-2.igen:11:5: error: ‘srcreg’ undeclared (first use in this function)
   11 |   srcreg = translate_rreg (SD_, RN2);
      |     ^~~~~~

(with this change)
  CC       mn10300/semantics.o
../../../sim/mn10300/am33-2.igen: In function ‘semantic_dcpf_D1a’:
../../../sim/mn10300/am33-2.igen:11:3: error: ‘srcreg’ undeclared (first use in this function)
   11 |   srcreg = translate_rreg (SD_, RN2);
      |   ^~~~~~
This commit is contained in:
Mike Frysinger 2023-12-14 22:29:56 -05:00
parent feb1ad0aec
commit 880530b71f
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
sim/igen/gen-semantics.c
View file

@ -262,10 +262,17 @@ print_semantic_body (lf *file,
{
/* true code */
lf_printf (file, "{\n");
lf_indent (file, +2);
/* NB: Do not indent the code. If the .igen source files cause a compiler
warning, the diagnostics can read the line from the original source,
but use column offsets from the generated files, causing columns to be
misaligned. It makes the generated code slightly more difficult to
read, but accurate compiler diagnostics relative to the original source
are more important here.
lf_indent (file, +2); */
lf_print__line_ref (file, instruction->code->line);
table_print_code (file, instruction->code);
lf_indent (file, -2);
/* NB: Disabled -- see above.
lf_indent (file, -2); */
lf_printf (file, "}\n");
lf_print__internal_ref (file);
}