FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove make_hex_string

Browse source 
I noticed that make_hex_string does essentially the same thing as
bin2hex, and furthermore is only called in a single spot.  This patch
removes make_hex_string.

Tested by the builtbot.

gdb/ChangeLog
2019-09-25  Tom Tromey  <tom@tromey.com>

	* python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
	* utils.h (make_hex_string): Don't declare.
	* utils.c (make_hex_string): Remove.
This commit is contained in:
Tom Tromey 2019-09-24 17:36:07 -06:00
parent 9a24a2763d
commit 858f25f0dd
4 changed files with 8 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/python/py-objfile.c
View file

@ -141,10 +141,9 @@ objfpy_get_build_id (PyObject *self, void *closure)
if (build_id != NULL)
{
gdb::unique_xmalloc_ptr<char> hex_form
(make_hex_string (build_id->data, build_id->size));
std::string hex_form = bin2hex (build_id->data, build_id->size);
return host_string_to_python_string (hex_form.get ()).release ();
return host_string_to_python_string (hex_form.c_str ()).release ();
}
Py_RETURN_NONE;