Implement repl evaluation for DAP
The evaluate command supports a "context" parameter which tells the adapter the context in which an evaluation occurs. One of the supported values is "repl", which we took to mean evaluation of a gdb command. That is what this patch implements. Note that some gdb commands probably will not work correctly with the rest of the protocol. For example if the user types "continue", confusion may result. This patch requires the earlier patch to fix up scopes in DAP.
This commit is contained in:
parent
9ed6d7410c
commit
84bc96de16
2 changed files with 26 additions and 3 deletions
|
@ -38,12 +38,30 @@ def _evaluate(expr, frame_id):
|
|||
return ref.to_object()
|
||||
|
||||
|
||||
# Helper function to evaluate a gdb command in a certain frame.
|
||||
@in_gdb_thread
|
||||
def _repl(command, frame_id):
|
||||
if frame_id is not None:
|
||||
frame = frame_for_id(frame_id)
|
||||
frame.select()
|
||||
val = gdb.execute(command, from_tty=True, to_string=True)
|
||||
return {
|
||||
"result": val,
|
||||
"variablesReference": 0,
|
||||
}
|
||||
|
||||
|
||||
# FIXME 'format' & hex
|
||||
# FIXME supportsVariableType handling
|
||||
# FIXME "repl"
|
||||
@request("evaluate")
|
||||
def eval_request(*, expression, frameId=None, **args):
|
||||
return send_gdb_with_response(lambda: _evaluate(expression, frameId))
|
||||
def eval_request(*, expression, frameId=None, context="variables", **args):
|
||||
if context in ("watch", "variables"):
|
||||
# These seem to be expression-like.
|
||||
return send_gdb_with_response(lambda: _evaluate(expression, frameId))
|
||||
elif context == "repl":
|
||||
return send_gdb_with_response(lambda: _repl(expression, frameId))
|
||||
else:
|
||||
raise Exception(f'unknown evaluate context "{context}"')
|
||||
|
||||
|
||||
@in_gdb_thread
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue