FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Iterate over 'struct varobj_item' instead of PyObject

Browse source 
In previous patch, "saved_item" is still a PyOjbect and iteration is
still performed over PyObject.  This patch continues to decouple
iteration from python code, so it changes its type to "struct
varobj_item *", so that the iterator itself is independent of python.

 V2:
 - Call varobj_delete_iter in free_variable.
 - Fix changelog entries.
 - Use XNEW.

 V3:
 - Return NULL early in py_varobj_iter_next if gdb_python_initialized
   is false.

gdb:

2014-06-12  Pedro Alves  <pedro@codesourcery.com>
	    Yao Qi  <yao@codesourcery.com>

	* python/py-varobj.c (py_varobj_iter_next): Return NULL if
	gdb_python_initialized is false.  Move some code from varobj.c.
	* varobj-iter.h (struct varobj_item): Moved from varobj.c.
	* varobj.c: Move "varobj-iter.h" inclusion earlier.
	(struct varobj_item): Moved to varobj-iter.h".
	(varobj_clear_saved_item): New function.
	(update_dynamic_varobj_children): Move python-related code to
	py-varobj.c.
	(free_variable): Call varobj_clear_saved_item and
	varobj_iter_delete.
This commit is contained in:
Yao Qi 2013-11-12 20:49:52 +08:00
parent e525021603
commit 827f100cee
4 changed files with 70 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

13
gdb/varobj-iter.h
View file

@ -14,9 +14,18 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
struct varobj_iter_ops;
/* A node or item of varobj, composed of the name and the value. */
typedef PyObject varobj_item;
typedef struct varobj_item
{
/* Name of this item. */
char *name;
/* Value of this item. */
struct value *value;
} varobj_item;
struct varobj_iter_ops;
/* A dynamic varobj iterator "class". */