FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: remove deprecated_exec_file_display_hook and associated code

Browse source 
This commit removes deprecated_exec_file_display_hook and the
associated specify_exec_file_hook.

The specify_exec_file_hook is used to add a new hook function to
deprecated_exec_file_display_hook, but is only used from the insight
debugger.

I posted a patch to remove the use of specify_exec_file_hook from
insight, and instead use gdb::observers::executable_changed, this
patch can be found here (it has now been merged):

  https://inbox.sourceware.org/insight/6abeb45e97d9004ec331e94cf2089af00553de76.1702379379.git.aburgess@redhat.com/T/#u

With this merged we can now cleanup the GDB side as this code is now
unused.

There should be no user visible changes after this commit.

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Andrew Burgess 2023-12-29 09:50:10 +00:00
parent 74d8fa2df7
commit 81b6f191f7
3 changed files with 0 additions and 76 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

67
gdb/corefile.c
View file

@ -35,73 +35,6 @@
#include "gdbarch.h"
#include "interps.h"
/* You can have any number of hooks for `exec_file_command' command to
call. If there's only one hook, it is set in exec_file_display
hook. If there are two or more hooks, they are set in
exec_file_extra_hooks[], and deprecated_exec_file_display_hook is
set to a function that calls all of them. This extra complexity is
needed to preserve compatibility with old code that assumed that
only one hook could be set, and which called
deprecated_exec_file_display_hook directly. */
typedef void (*hook_type) (const char *);
hook_type deprecated_exec_file_display_hook; /* The original hook. */
static hook_type *exec_file_extra_hooks; /* Array of additional
hooks. */
static int exec_file_hook_count = 0; /* Size of array. */
/* If there are two or more functions that wish to hook into
exec_file_command, this function will call all of the hook
functions. */
static void
call_extra_exec_file_hooks (const char *filename)
{
int i;
for (i = 0; i < exec_file_hook_count; i++)
(*exec_file_extra_hooks[i]) (filename);
}
/* Call this to specify the hook for exec_file_command to call back.
This is called from the x-window display code. */
void
specify_exec_file_hook (void (*hook) (const char *))
{
hook_type *new_array;
if (deprecated_exec_file_display_hook != NULL)
{
/* There's already a hook installed. Arrange to have both it
and the subsequent hooks called. */
if (exec_file_hook_count == 0)
{
/* If this is the first extra hook, initialize the hook
array. */
exec_file_extra_hooks = XNEW (hook_type);
exec_file_extra_hooks[0] = deprecated_exec_file_display_hook;
deprecated_exec_file_display_hook = call_extra_exec_file_hooks;
exec_file_hook_count = 1;
}
/* Grow the hook array by one and add the new hook to the end.
Yes, it's inefficient to grow it by one each time but since
this is hardly ever called it's not a big deal. */
exec_file_hook_count++;
new_array = (hook_type *)
xrealloc (exec_file_extra_hooks,
exec_file_hook_count * sizeof (hook_type));
exec_file_extra_hooks = new_array;
exec_file_extra_hooks[exec_file_hook_count - 1] = hook;
}
else
deprecated_exec_file_display_hook = hook;
}
void
reopen_exec_file (void)
{

4
gdb/exec.c
View file

@ -494,10 +494,6 @@ exec_file_attach (const char *filename, int from_tty)
target. */
current_program_space->add_target_sections
(current_program_space->ebfd.get (), sections);
/* Tell display code (if any) about the changed file name. */
if (deprecated_exec_file_display_hook)
(*deprecated_exec_file_display_hook) (filename);
}
/* Are are loading the same executable? */

5
gdb/gdbcore.h
View file

@ -114,17 +114,12 @@ extern void write_memory_signed_integer (CORE_ADDR addr, int len,
enum bfd_endian byte_order,
LONGEST value);
/* Hook for `exec_file_command' command to call. */
extern void (*deprecated_exec_file_display_hook) (const char *filename);
/* Hook for "file_command", which is more useful than above
(because it is invoked AFTER symbols are read, not before). */
extern void (*deprecated_file_changed_hook) (const char *filename);
extern void specify_exec_file_hook (void (*hook) (const char *filename));
/* Binary File Diddler for the core file. */
#define core_bfd (current_program_space->cbfd.get ())