FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

alpha-vms: sanity checks for image_write

Browse source 
* vms-alpha.c (image_write): Check bounds for sections without
	contents too.  Error on non-zero write to section without
	contents.
	(_bfd_vms_slurp_etir): Check return of image_write* functions.
This commit is contained in:
Alan Modra 2020-03-31 14:53:27 +10:30
parent b3b360dec7
commit 8169954446
2 changed files with 52 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

7
bfd/ChangeLog
View file

@ -1,3 +1,10 @@
2020-03-31 Alan Modra <amodra@gmail.com>
* vms-alpha.c (image_write): Check bounds for sections without
contents too. Error on non-zero write to section without
contents.
(_bfd_vms_slurp_etir): Check return of image_write* functions.
2020-03-31 Alan Modra <amodra@gmail.com> 2020-03-31 Alan Modra <amodra@gmail.com>
* tekhex.c (pass_over): Check is_eof before reading buffer. * tekhex.c (pass_over): Check is_eof before reading buffer.

58
bfd/vms-alpha.c
View file

@ -1610,13 +1610,6 @@ dst_retrieve_location (bfd *abfd, bfd_vma *loc)
static bfd_boolean static bfd_boolean
image_write (bfd *abfd, unsigned char *ptr, unsigned int size) image_write (bfd *abfd, unsigned char *ptr, unsigned int size)
{
#if VMS_DEBUG
_bfd_vms_debug (8, "image_write from (%p, %d) to (%ld)\n", ptr, size,
(long)PRIV (image_offset));
#endif
if (PRIV (image_section)->contents != NULL)
{ {
asection *sec = PRIV (image_section); asection *sec = PRIV (image_section);
size_t off = PRIV (image_offset); size_t off = PRIV (image_offset);
@ -1629,8 +1622,24 @@ image_write (bfd *abfd, unsigned char *ptr, unsigned int size)
return FALSE; return FALSE;
} }
#if VMS_DEBUG
_bfd_vms_debug (8, "image_write from (%p, %d) to (%ld)\n", ptr, size,
(long) off));
#endif
if (PRIV (image_section)->contents != NULL)
memcpy (sec->contents + off, ptr, size); memcpy (sec->contents + off, ptr, size);
else
{
unsigned int i;
for (i = 0; i < size; i++)
if (ptr[i] != 0)
{
bfd_set_error (bfd_error_bad_value);
return FALSE;
} }
}
#if VMS_DEBUG #if VMS_DEBUG
_bfd_hexdump (9, ptr, size, 0); _bfd_hexdump (9, ptr, size, 0);
#endif #endif
@ -1998,7 +2007,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
return FALSE; return FALSE;
if (rel1 != RELC_NONE) if (rel1 != RELC_NONE)
goto bad_context; goto bad_context;
image_write_b (abfd, (unsigned int) op1 & 0xff); if (!image_write_b (abfd, (unsigned int) op1 & 0xff))
return FALSE;
break; break;
/* Store word: pop stack, write word /* Store word: pop stack, write word
@ -2008,7 +2018,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
return FALSE; return FALSE;
if (rel1 != RELC_NONE) if (rel1 != RELC_NONE)
goto bad_context; goto bad_context;
image_write_w (abfd, (unsigned int) op1 & 0xffff); if (!image_write_w (abfd, (unsigned int) op1 & 0xffff))
return FALSE;
break; break;
/* Store longword: pop stack, write longword /* Store longword: pop stack, write longword
@ -2034,7 +2045,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
if (!alpha_vms_add_lw_reloc (info)) if (!alpha_vms_add_lw_reloc (info))
return FALSE; return FALSE;
} }
image_write_l (abfd, op1); if (!image_write_l (abfd, op1))
return FALSE;
break; break;
/* Store quadword: pop stack, write quadword /* Store quadword: pop stack, write quadword
@ -2056,7 +2068,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
if (!alpha_vms_add_qw_reloc (info)) if (!alpha_vms_add_qw_reloc (info))
return FALSE; return FALSE;
} }
image_write_q (abfd, op1); if (!image_write_q (abfd, op1))
return FALSE;
break; break;
/* Store immediate repeated: pop stack for repeat count /* Store immediate repeated: pop stack for repeat count
@ -2074,7 +2087,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
if (rel1 != RELC_NONE) if (rel1 != RELC_NONE)
goto bad_context; goto bad_context;
while (op1-- > 0) while (op1-- > 0)
image_write (abfd, ptr + 4, size); if (!image_write (abfd, ptr + 4, size))
return FALSE;
} }
break; break;
@ -2099,7 +2113,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
return FALSE; return FALSE;
} }
} }
image_write_q (abfd, op1); if (!image_write_q (abfd, op1))
return FALSE;
break; break;
/* Store code address: write address of entry point /* Store code address: write address of entry point
@ -2131,7 +2146,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
abort (); abort ();
} }
} }
image_write_q (abfd, op1); if (!image_write_q (abfd, op1))
return FALSE;
break; break;
/* Store offset to psect: pop stack, add low 32 bits to base of psect /* Store offset to psect: pop stack, add low 32 bits to base of psect
@ -2145,7 +2161,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
op1 = alpha_vms_fix_sec_rel (abfd, info, rel1, op1); op1 = alpha_vms_fix_sec_rel (abfd, info, rel1, op1);
rel1 = RELC_REL; rel1 = RELC_REL;
image_write_q (abfd, op1); if (!image_write_q (abfd, op1))
return FALSE;
break; break;
/* Store immediate /* Store immediate
@ -2158,7 +2175,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
if (ptr + 4 > maxptr) if (ptr + 4 > maxptr)
goto corrupt_etir; goto corrupt_etir;
size = bfd_getl32 (ptr); size = bfd_getl32 (ptr);
image_write (abfd, ptr + 4, size); if (!image_write (abfd, ptr + 4, size))
return FALSE;
} }
break; break;
@ -2173,7 +2191,8 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
#if 0 #if 0
abort (); abort ();
#endif #endif
image_write_l (abfd, op1); if (!image_write_l (abfd, op1))
return FALSE;
break; break;
case ETIR__C_STO_RB: case ETIR__C_STO_RB:
@ -2246,8 +2265,9 @@ _bfd_vms_slurp_etir (bfd *abfd, struct bfd_link_info *info)
op1 = 0; op1 = 0;
op2 = 0; op2 = 0;
} }
image_write_q (abfd, op1); if (!image_write_q (abfd, op1)
image_write_q (abfd, op2); || !image_write_q (abfd, op2))
return FALSE;
break; break;
/* 205 Store-conditional NOP at address of global /* 205 Store-conditional NOP at address of global