FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix PR python/20129 - use of non-existing variable

Browse source 
PR python/20129 concerns the error message one gets from a command
like "disable frame-filter global NoSuchFilter".  Currently this
throws a second, unexpected, exception due to the use of a
non-existing variable named "name".

This patch adds regression tests and fixes a couple of spots to use
the correct variable name.

Built and regtested on x86-64 Fedora 23.

2016-06-29  Tom Tromey  <tom@tromey.com>

	PR python/20129:
	* python/lib/gdb/command/frame_filters.py (_do_enable_frame_filter)
	(SetFrameFilterPriority._set_filter_priority): Use "frame_filter",
	not "name".

2016-06-29  Tom Tromey  <tom@tromey.com>

	PR python/20129:
	* gdb.python/py-framefilter.exp: Add tests for setting priority
	and disabling of non-existent frame filter.
This commit is contained in:
Tom Tromey 2016-06-06 11:21:15 -06:00
parent 9d78f827e0
commit 803b47e5d4
4 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
gdb/ChangeLog
View file

@ -1,3 +1,10 @@
2016-06-29 Tom Tromey <tom@tromey.com>
PR python/20129:
* python/lib/gdb/command/frame_filters.py (_do_enable_frame_filter)
(SetFrameFilterPriority._set_filter_priority): Use "frame_filter",
not "name".
2016-06-29 Tom Tromey <tom@tromey.com> 2016-06-29 Tom Tromey <tom@tromey.com>
PR gdb/17210: PR gdb/17210:

4
gdb/python/lib/gdb/command/frame_filters.py
View file

@ -142,7 +142,7 @@ def _do_enable_frame_filter(command_tuple, flag):
try: try:
ff = op_list[frame_filter] ff = op_list[frame_filter]
except KeyError: except KeyError:
msg = "frame-filter '" + str(name) + "' not found." msg = "frame-filter '" + str(frame_filter) + "' not found."
raise gdb.GdbError(msg) raise gdb.GdbError(msg)
gdb.frames.set_enabled(ff, flag) gdb.frames.set_enabled(ff, flag)
@ -339,7 +339,7 @@ class SetFrameFilterPriority(gdb.Command):
try: try:
ff = op_list[frame_filter] ff = op_list[frame_filter]
except KeyError: except KeyError:
msg = "frame-filter '" + str(name) + "' not found." msg = "frame-filter '" + str(frame_filter) + "' not found."
raise gdb.GdbError(msg) raise gdb.GdbError(msg)
gdb.frames.set_priority(ff, priority) gdb.frames.set_priority(ff, priority)

6
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,9 @@
2016-06-29 Tom Tromey <tom@tromey.com>
PR python/20129:
* gdb.python/py-framefilter.exp: Add tests for setting priority
and disabling of non-existent frame filter.
2016-06-29 Yao Qi <yao.qi@linaro.org> 2016-06-29 Yao Qi <yao.qi@linaro.org>
* gdb.base/catch-syscall.c [__arm__]: Set unknown_syscall to * gdb.base/catch-syscall.c [__arm__]: Set unknown_syscall to

6
gdb/testsuite/gdb.python/py-framefilter.exp
View file

@ -108,6 +108,9 @@ gdb_test "show frame-filter priority global Elider" \
gdb_test "info frame-filter" \ gdb_test "info frame-filter" \
".*1000.*Yes.*Elider.*100.*Yes.*Reverse.*10.*.*No.*Object.*1.*" \ ".*1000.*Yes.*Elider.*100.*Yes.*Reverse.*10.*.*No.*Object.*1.*" \
"info frame filter after setting priority" "info frame filter after setting priority"
gdb_test "set frame-filter priority global NoSuchFilter 900" \
"frame-filter 'NoSuchFilter' not found." \
"set priority of a non-existing filter"
# Test enable/disable # Test enable/disable
gdb_test "info frame-filter" \ gdb_test "info frame-filter" \
@ -123,6 +126,9 @@ gdb_test_no_output "enable frame-filter global Elider" \
gdb_test "info frame-filter" \ gdb_test "info frame-filter" \
".*1000.*Yes.*Elider.*100.*Yes.*Reverse.*10.*.*No.*Object.*1.*" \ ".*1000.*Yes.*Elider.*100.*Yes.*Reverse.*10.*.*No.*Object.*1.*" \
"info frame filter after reenabling frame filter" "info frame filter after reenabling frame filter"
gdb_test "disable frame-filter global NoSuchFilter" \
"frame-filter 'NoSuchFilter' not found." \
"disable a non-existing filter"
# Test no-filters # Test no-filters
gdb_test "bt no-filters" \ gdb_test "bt no-filters" \