FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Introduce program_space::add_objfile

Browse source 
This introduces a new method, program_space::add_objfile, that adds an
objfile to the program space's list of objfiles.  It also changes the
obfile's constructor so that linking an objfile into this list is not
done here.

The former is an improvement because it makes more sense to treat the
program space as a container holding objfiles -- so manipulation of
the list belongs there.

The latter is not strictly needed, but seemed better both because it
is removing a global side effect from a constructor, and for symmetry
reasons, as a subsequent patch will remove unlinking from the
destructor.

gdb/ChangeLog
2019-12-12  Tom Tromey  <tom@tromey.com>

	* progspace.h (struct program_space) <add_objfile>: Declare
	method.
	* progspace.c (program_space::add_objfile): New method.
	* objfiles.c (~objfile): Don't unlink objfile.
	(put_objfile_before): Remove.
	(add_separate_debug_objfile): Don't call put_objfile_before.
	(objfile::make): Call add_objfile.  Set new_objfiles_available on
	the per-program-space data.

Change-Id: I93e8525dda631cb89dcc2046a5c51c7c9f34ccfd
This commit is contained in:
Tom Tromey 2019-11-01 16:31:28 -06:00
parent 268e4f0914
commit 7cac64af7b
4 changed files with 45 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

22
gdb/progspace.c
View file

@ -153,6 +153,28 @@ program_space::~program_space ()
program_space_free_data (this);
}
/* See progspace.h. */
void
program_space::add_objfile (struct objfile *objfile, struct objfile *before)
{
for (struct objfile **objp = &objfiles_head;
*objp != NULL;
objp = &((*objp)->next))
{
if (*objp == before)
{
objfile->next = *objp;
*objp = objfile;
return;
}
}
internal_error (__FILE__, __LINE__,
_("put_objfile_before: before objfile not in list"));
}
/* Copies program space SRC to DEST. Copies the main executable file,
and the main symbol file. Returns DEST. */