FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change return type of ui_out redirect to void

Browse source 
All implementations of redirect/do_redirect in the ui_out subsystem
always return 0 (success).  We can therefore clean it up and make them
return void.

gdb/ChangeLog:

	* cli-out.c (cli_ui_out::do_redirect): Change return type to
	void.
	* cli-out.h (cli_ui_out::do_redirect): Likewise.
	* mi/mi-out.c (mi_ui_out::do_redirect): Likewise.
	* mi/mi-out.h (mi_ui_out::do_redirect): Likewise.
	* ui-out.c (ui_out::redirect): Likewise.
	* ui-out.h (ui_out::redirect, ui_out::do_redirect): Likewise.
	* cli/cli-logging.c (set_logging_redirect): Update call site of
	ui_out::redirect.
	(handle_redirections): Likewise.
	* scm-ports.c (ioscm_with_output_to_port_worker): Likewise.
	* top.c (execute_command_to_string): Likewise.
	* utils.c (do_ui_out_redirect_pop): Likewise.
This commit is contained in:
Simon Marchi 2017-01-10 11:30:47 -05:00
parent 98461510d3
commit 7becfd03ba
11 changed files with 34 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

15
gdb/cli/cli-logging.c
View file

@ -130,13 +130,11 @@ set_logging_redirect (char *args, int from_tty, struct cmd_list_element *c)
/* There is a former output pushed on the ui_out_redirect stack. We
want to replace it by OUTPUT so we must pop the former value
first. We should either do both the pop and push or to do
neither of it. At least do not try to push OUTPUT if the pop
already failed. */
first. Ideally, we should either do both the pop and push or do
neither of them. */
if (uiout->redirect (NULL) < 0
|| uiout->redirect (output) < 0)
warning (_("Current output protocol does not support redirection"));
uiout->redirect (NULL);
uiout->redirect (output);
do_cleanups (cleanups);
}
@ -246,10 +244,7 @@ handle_redirections (int from_tty)
/* Don't do the redirect for MI, it confuses MI's ui-out scheme. */
if (!current_uiout->is_mi_like_p ())
{
if (current_uiout->redirect (output) < 0)
warning (_("Current output protocol does not support redirection"));
}
current_uiout->redirect (output);
}
static void