FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ECOFF slurp_relocs thinko

Browse source 
In git commit 806470a219 I swapped the order of internal vs. external
relocs memory allocation in ecoff_slurp_reloc_table, the idea being
that the external reloc size can be sanity checked against file size.
However, that fails badly with bfd_alloc memory where releasing any
block also releases all more recently allocated blocks.

	* ecoff.c (ecoff_slurp_reloc_table): Malloc external_relocs so
	they can be freed without also freeing internal_relocs.
This commit is contained in:
Alan Modra 2020-05-18 20:44:30 +09:30
parent ca859a8939
commit 7a87e9c805
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
bfd/ChangeLog
View file

@ -1,3 +1,8 @@
2020-05-18 Alan Modra <amodra@gmail.com>
* ecoff.c (ecoff_slurp_reloc_table): Malloc external_relocs so
they can be freed without also freeing internal_relocs.
2020-05-18 Jaydeep Chauhan <jaydeepchauhan1494@gmail.com>
PR 25713

6
bfd/ecoff.c
View file

@ -1626,7 +1626,7 @@ ecoff_slurp_reloc_table (bfd *abfd,
amt = external_reloc_size * section->reloc_count;
if (bfd_seek (abfd, section->rel_filepos, SEEK_SET) != 0)
return FALSE;
external_relocs = _bfd_alloc_and_read (abfd, amt, amt);
external_relocs = _bfd_malloc_and_read (abfd, amt, amt);
if (external_relocs == NULL)
return FALSE;
@ -1635,7 +1635,7 @@ ecoff_slurp_reloc_table (bfd *abfd,
internal_relocs = (arelent *) bfd_alloc (abfd, amt);
if (internal_relocs == NULL)
{
bfd_release (abfd, external_relocs);
free (external_relocs);
return FALSE;
}
@ -1703,7 +1703,7 @@ ecoff_slurp_reloc_table (bfd *abfd,
(*backend->adjust_reloc_in) (abfd, &intern, rptr);
}
bfd_release (abfd, external_relocs);
free (external_relocs);
section->relocation = internal_relocs;