FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Consistently Use ui_file parameter to show callbacks

Browse source 
I happened to notice that one "show" callback was printing to
gdb_stdout rather than to the passed-in ui_file parameter.  I went
through all such callbacks and fixed them to consistently use the
ui_file.

Regression tested on x86-64 Fedora 34.
This commit is contained in:
Tom Tromey 2021-12-28 14:10:11 -07:00
parent de4686ffaf
commit 7514a66128
11 changed files with 46 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

12
gdb/source.c
View file

@ -400,11 +400,11 @@ set_directories_command (const char *args,
function. */
static void
show_directories_1 (char *ignore, int from_tty)
show_directories_1 (ui_file *file, char *ignore, int from_tty)
{
puts_filtered ("Source directories searched: ");
puts_filtered (source_path.c_str ());
puts_filtered ("\n");
fputs_filtered ("Source directories searched: ", file);
fputs_filtered (source_path.c_str (), file);
fputs_filtered ("\n", file);
}
/* Handler for "show directories" command. */
@ -413,7 +413,7 @@ static void
show_directories_command (struct ui_file *file, int from_tty,
struct cmd_list_element *c, const char *value)
{
show_directories_1 (NULL, from_tty);
show_directories_1 (file, NULL, from_tty);
}
/* See source.h. */
@ -485,7 +485,7 @@ directory_command (const char *dirname, int from_tty)
gdb::observers::command_param_changed.notify ("directories",
source_path.c_str ());
if (from_tty)
show_directories_1 ((char *) 0, from_tty);
show_directories_1 (gdb_stdout, (char *) 0, from_tty);
}
}