FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Consistently Use ui_file parameter to show callbacks

Browse source 
I happened to notice that one "show" callback was printing to
gdb_stdout rather than to the passed-in ui_file parameter.  I went
through all such callbacks and fixed them to consistently use the
ui_file.

Regression tested on x86-64 Fedora 34.
This commit is contained in:
Tom Tromey 2021-12-28 14:10:11 -07:00
parent de4686ffaf
commit 7514a66128
11 changed files with 46 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

20
gdb/remote.c
View file

@ -1065,8 +1065,6 @@ static int stub_unpack_int (const char *buff, int fieldlength);
struct packet_config;
static void show_packet_config_cmd (struct packet_config *config);
static void show_remote_protocol_packet_cmd (struct ui_file *file,
int from_tty,
struct cmd_list_element *c,
@ -1913,7 +1911,7 @@ static enum packet_support packet_config_support (struct packet_config *config);
static enum packet_support packet_support (int packet);
static void
show_packet_config_cmd (struct packet_config *config)
show_packet_config_cmd (ui_file *file, struct packet_config *config)
{
const char *support = "internal-error";
@ -1932,14 +1930,16 @@ show_packet_config_cmd (struct packet_config *config)
switch (config->detect)
{
case AUTO_BOOLEAN_AUTO:
printf_filtered (_("Support for the `%s' packet "
"is auto-detected, currently %s.\n"),
config->name, support);
fprintf_filtered (file,
_("Support for the `%s' packet "
"is auto-detected, currently %s.\n"),
config->name, support);
break;
case AUTO_BOOLEAN_TRUE:
case AUTO_BOOLEAN_FALSE:
printf_filtered (_("Support for the `%s' packet is currently %s.\n"),
config->name, support);
fprintf_filtered (file,
_("Support for the `%s' packet is currently %s.\n"),
config->name, support);
break;
}
}
@ -2275,7 +2275,7 @@ show_remote_protocol_packet_cmd (struct ui_file *file, int from_tty,
{
if (c == packet->show_cmd)
{
show_packet_config_cmd (packet);
show_packet_config_cmd (file, packet);
return;
}
}
@ -2319,7 +2319,7 @@ show_remote_protocol_Z_packet_cmd (struct ui_file *file, int from_tty,
for (i = 0; i < NR_Z_PACKET_TYPES; i++)
{
show_packet_config_cmd (&remote_protocol_packets[PACKET_Z0 + i]);
show_packet_config_cmd (file, &remote_protocol_packets[PACKET_Z0 + i]);
}
}