FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use gdbpy_ref in py_print_frame

Browse source 
This changes py_print_frame to use gdbpy_ref in more places.

2017-01-10  Tom Tromey  <tom@tromey.com>

	* python/py-framefilter.c (py_print_frame): Use gdbpy_ref.
This commit is contained in:
Tom Tromey 2016-11-20 10:27:59 -07:00
parent 16361ffbd1
commit 74c49d454b
2 changed files with 8 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
gdb/ChangeLog
View file

@ -1,3 +1,7 @@
2017-01-10 Tom Tromey <tom@tromey.com>
* python/py-framefilter.c (py_print_frame): Use gdbpy_ref.
2017-01-10 Tom Tromey <tom@tromey.com> 2017-01-10 Tom Tromey <tom@tromey.com>
* python/py-finishbreakpoint.c (bpfinishpy_out_of_scope): Use * python/py-finishbreakpoint.c (bpfinishpy_out_of_scope): Use

14
gdb/python/py-framefilter.c
View file

@ -1009,7 +1009,6 @@ py_print_frame (PyObject *filter, int flags,
struct frame_info *frame = NULL; struct frame_info *frame = NULL;
struct cleanup *cleanup_stack; struct cleanup *cleanup_stack;
struct value_print_options opts; struct value_print_options opts;
PyObject *py_inf_frame;
int print_level, print_frame_info, print_args, print_locals; int print_level, print_frame_info, print_args, print_locals;
gdb::unique_xmalloc_ptr<char> function_to_free; gdb::unique_xmalloc_ptr<char> function_to_free;
@ -1024,14 +1023,11 @@ py_print_frame (PyObject *filter, int flags,
/* Get the underlying frame. This is needed to determine GDB /* Get the underlying frame. This is needed to determine GDB
architecture, and also, in the cases of frame variables/arguments to architecture, and also, in the cases of frame variables/arguments to
read them if they returned filter object requires us to do so. */ read them if they returned filter object requires us to do so. */
py_inf_frame = PyObject_CallMethod (filter, "inferior_frame", NULL); gdbpy_ref py_inf_frame (PyObject_CallMethod (filter, "inferior_frame", NULL));
if (py_inf_frame == NULL) if (py_inf_frame == NULL)
return EXT_LANG_BT_ERROR; return EXT_LANG_BT_ERROR;
frame = frame_object_to_frame_info (py_inf_frame);; frame = frame_object_to_frame_info (py_inf_frame.get ());
Py_DECREF (py_inf_frame);
if (frame == NULL) if (frame == NULL)
return EXT_LANG_BT_ERROR; return EXT_LANG_BT_ERROR;
@ -1085,7 +1081,7 @@ py_print_frame (PyObject *filter, int flags,
address printing. */ address printing. */
if (PyObject_HasAttrString (filter, "address")) if (PyObject_HasAttrString (filter, "address"))
{ {
PyObject *paddr = PyObject_CallMethod (filter, "address", NULL); gdbpy_ref paddr (PyObject_CallMethod (filter, "address", NULL));
if (paddr == NULL) if (paddr == NULL)
{ {
@ -1095,16 +1091,14 @@ py_print_frame (PyObject *filter, int flags,
if (paddr != Py_None) if (paddr != Py_None)
{ {
if (get_addr_from_python (paddr, &address) < 0) if (get_addr_from_python (paddr.get (), &address) < 0)
{ {
Py_DECREF (paddr);
do_cleanups (cleanup_stack); do_cleanups (cleanup_stack);
return EXT_LANG_BT_ERROR; return EXT_LANG_BT_ERROR;
} }
has_addr = 1; has_addr = 1;
} }
Py_DECREF (paddr);
} }
} }