FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rename frame_stop_reason_string to unwind_stop_reason_to_string.

Browse source 
https://sourceware.org/ml/gdb-patches/2014-05/msg00721.html

This function is confusingly named, the "frame_" in the name implies it
somehow is frame dependent, when in reality the function just converts an
'enum unwind_stop_reason' value to a string.

gdb/ChangeLog:

	* frame.c (frame_stop_reason_string): Rename to ...
	(unwind_stop_reason_to_string): this.
	* frame.h (frame_stop_reason_string): Rename to ...
	(unwind_stop_reason_to_string): this.
	* stack.c (frame_info): Update call to frame_stop_reason_string.
	(backtrace_command_1): Likewise.
	* guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Likewise.
	* python/py-frame.c (gdbpy_frame_stop_reason_string): Likewise.
This commit is contained in:
Andrew Burgess 2014-05-28 22:46:33 +01:00
parent 938f0e2f67
commit 70e38b8e98
6 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
gdb/ChangeLog
View file

@ -1,3 +1,14 @@
2014-05-30 Andrew Burgess <aburgess@broadcom.com>
* frame.c (frame_stop_reason_string): Rename to ...
(unwind_stop_reason_to_string): this.
* frame.h (frame_stop_reason_string): Rename to ...
(unwind_stop_reason_to_string): this.
* stack.c (frame_info): Update call to frame_stop_reason_string.
(backtrace_command_1): Likewise.
* guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Likewise.
* python/py-frame.c (gdbpy_frame_stop_reason_string): Likewise.
2014-05-30 Andrew Burgess <aburgess@broadcom.com> 2014-05-30 Andrew Burgess <aburgess@broadcom.com>
* frame.c (remove_prev_frame): New function. * frame.c (remove_prev_frame): New function.

2
gdb/frame.c
View file

@ -2561,7 +2561,7 @@ get_frame_unwind_stop_reason (struct frame_info *frame)
/* Return a string explaining REASON. */ /* Return a string explaining REASON. */
const char * const char *
frame_stop_reason_string (enum unwind_stop_reason reason) unwind_stop_reason_to_string (enum unwind_stop_reason reason)
{ {
switch (reason) switch (reason)
{ {

2
gdb/frame.h
View file

@ -503,7 +503,7 @@ enum unwind_stop_reason get_frame_unwind_stop_reason (struct frame_info *);
/* Translate a reason code to an informative string. */ /* Translate a reason code to an informative string. */
const char *frame_stop_reason_string (enum unwind_stop_reason); const char *unwind_stop_reason_to_string (enum unwind_stop_reason);
/* Unwind the stack frame so that the value of REGNUM, in the previous /* Unwind the stack frame so that the value of REGNUM, in the previous
(up, older) frame is returned. If VALUEP is NULL, don't (up, older) frame is returned. If VALUEP is NULL, don't

2
gdb/guile/scm-frame.c
View file

@ -933,7 +933,7 @@ gdbscm_unwind_stop_reason_string (SCM reason_scm)
if (reason < UNWIND_FIRST || reason > UNWIND_LAST) if (reason < UNWIND_FIRST || reason > UNWIND_LAST)
scm_out_of_range (FUNC_NAME, reason_scm); scm_out_of_range (FUNC_NAME, reason_scm);
str = frame_stop_reason_string (reason); str = unwind_stop_reason_to_string (reason);
return gdbscm_scm_from_c_string (str); return gdbscm_scm_from_c_string (str);
} }

2
gdb/python/py-frame.c
View file

@ -588,7 +588,7 @@ gdbpy_frame_stop_reason_string (PyObject *self, PyObject *args)
return NULL; return NULL;
} }
str = frame_stop_reason_string (reason); str = unwind_stop_reason_to_string (reason);
return PyUnicode_Decode (str, strlen (str), host_charset (), NULL); return PyUnicode_Decode (str, strlen (str), host_charset (), NULL);
} }

4
gdb/stack.c
View file

@ -1529,7 +1529,7 @@ frame_info (char *addr_exp, int from_tty)
reason = get_frame_unwind_stop_reason (fi); reason = get_frame_unwind_stop_reason (fi);
if (reason != UNWIND_NO_REASON) if (reason != UNWIND_NO_REASON)
printf_filtered (_(" Outermost frame: %s\n"), printf_filtered (_(" Outermost frame: %s\n"),
frame_stop_reason_string (reason)); unwind_stop_reason_to_string (reason));
} }
else if (get_frame_type (fi) == TAILCALL_FRAME) else if (get_frame_type (fi) == TAILCALL_FRAME)
puts_filtered (" tail call frame"); puts_filtered (" tail call frame");
@ -1848,7 +1848,7 @@ backtrace_command_1 (char *count_exp, int show_locals, int no_filters,
reason = get_frame_unwind_stop_reason (trailing); reason = get_frame_unwind_stop_reason (trailing);
if (reason >= UNWIND_FIRST_ERROR) if (reason >= UNWIND_FIRST_ERROR)
printf_filtered (_("Backtrace stopped: %s\n"), printf_filtered (_("Backtrace stopped: %s\n"),
frame_stop_reason_string (reason)); unwind_stop_reason_to_string (reason));
} }
} }
} }