FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* solib-svr4.c (enable_break): Update.

Browse source 
* bfd-target.h (target_bfd_reopen): Update documentation.
This commit is contained in:
Tom Tromey 2012-07-23 15:25:12 +00:00
parent 08d2cd740c
commit 695c31738b
3 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2012-07-23 Tom Tromey <tromey@redhat.com>
* solib-svr4.c (enable_break): Update.
* bfd-target.h (target_bfd_reopen): Update documentation.
2012-07-23 Tom Tromey <tromey@redhat.com>
* symfile.c (separate_debug_file_exists): Update.

6
gdb/bfd-target.h
View file

@ -23,9 +23,9 @@
struct bfd;
struct target_ops;
/* Given an existing BFD, re-open it as a "struct target_ops". On
close, it will also close the corresponding BFD (which is like
freopen and fdopen). */
/* Given an existing BFD, re-open it as a "struct target_ops". This
acquires a new reference to the BFD. This reference will be
released when the target is closed. */
struct target_ops *target_bfd_reopen (struct bfd *bfd);
#endif

12
gdb/solib-svr4.c
View file

@ -46,6 +46,7 @@
#include "exec.h"
#include "auxv.h"
#include "exceptions.h"
#include "gdb_bfd.h"
static struct link_map_offsets *svr4_fetch_link_map_offsets (void);
static int svr4_have_link_map_offsets (void);
@ -1558,9 +1559,11 @@ enable_break (struct svr4_info *info, int from_tty)
goto bkpt_at_symbol;
/* Now convert the TMP_BFD into a target. That way target, as
well as BFD operations can be used. Note that closing the
target will also close the underlying bfd. */
well as BFD operations can be used. */
tmp_bfd_target = target_bfd_reopen (tmp_bfd);
/* target_bfd_reopen acquired its own reference, so we can
release ours now. */
gdb_bfd_unref (tmp_bfd);
/* On a running target, we can get the dynamic linker's base
address from the shared library table. */
@ -1670,8 +1673,9 @@ enable_break (struct svr4_info *info, int from_tty)
sym_addr,
tmp_bfd_target);
/* We're done with both the temporary bfd and target. Remember,
closing the target closes the underlying bfd. */
/* We're done with both the temporary bfd and target. Closing
the target closes the underlying bfd, because it holds the
only remaining reference. */
target_close (tmp_bfd_target, 0);
if (sym_addr != 0)