FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make dwarf_stack_value::in_stack_memory a bool

Browse source 
Replace int with bool, because that's what it is.

gdb/ChangeLog:

	* dwarf2expr.h (dwarf_expr_piece) <v.mem.in_stack_memory>:
	Change type to bool.
	(dwarf_stack_value) <in_stack_memory>: Likewise.
	(dwarf_expr_context) <push_address>: Change parameter type to
	bool.
	<fetch_in_stack_memory>: Change return type to bool.
	<push>: Change parameter type to bool.
	* dwarf2expr.c (dwarf_expr_context::push): Change parameter type
	to bool.
	(dwarf_expr_context::push_address): Likewise.
	(dwarf_expr_context::fetch_in_stack_memory): Change return type
	to bool.
	(dwarf_expr_context::execute_stack_op): Adjust.
	* dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Adjust.
This commit is contained in:
Simon Marchi 2017-09-14 16:13:33 +02:00
parent 1e46716193
commit 690098826e
4 changed files with 35 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

19
gdb/dwarf2expr.h
View file

@ -62,7 +62,7 @@ struct dwarf_expr_piece
CORE_ADDR addr;
/* Non-zero if the piece is known to be in memory and on
the program's stack. */
int in_stack_memory;
bool in_stack_memory;
} mem;
/* The piece's register number, for DWARF_VALUE_REGISTER pieces. */
@ -102,12 +102,11 @@ struct dwarf_stack_value
{
struct value *value;
/* Non-zero if the piece is in memory and is known to be
on the program's stack. It is always ok to set this to zero.
This is used, for example, to optimize memory access from the target.
It can vastly speed up backtraces on long latency connections when
"set stack-cache on". */
int in_stack_memory;
/* True if the piece is in memory and is known to be on the program's stack.
It is always ok to set this to zero. This is used, for example, to
optimize memory access from the target. It can vastly speed up backtraces
on long latency connections when "set stack-cache on". */
bool in_stack_memory;
};
/* The expression evaluator works with a dwarf_expr_context, describing
@ -117,11 +116,11 @@ struct dwarf_expr_context
dwarf_expr_context ();
virtual ~dwarf_expr_context ();
void push_address (CORE_ADDR value, int in_stack_memory);
void push_address (CORE_ADDR value, bool in_stack_memory);
void eval (const gdb_byte *addr, size_t len);
struct value *fetch (int n);
CORE_ADDR fetch_address (int n);
int fetch_in_stack_memory (int n);
bool fetch_in_stack_memory (int n);
/* The stack of values, allocated with xmalloc. */
struct dwarf_stack_value *stack;
@ -251,7 +250,7 @@ private:
struct type *address_type () const;
void grow_stack (size_t need);
void push (struct value *value, int in_stack_memory);
void push (struct value *value, bool in_stack_memory);
int stack_empty_p () const;
void add_piece (ULONGEST size, ULONGEST offset);
void execute_stack_op (const gdb_byte *op_ptr, const gdb_byte *op_end);