FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: Remove LANG_MAGIC

Browse source 
The language_defn structure has an la_magic field, this used to be
used as a basic check that the language_defn structure had the
expected layout - at least the end of the structure was where we
expected it to be.

This feature only really makes sense if we imagine GDB dynamically
loading language support from dynamic libraries, where a version
mismatch might cause problems.

However, in current GDB language support is statically built into GDB,
and since this commit:

    commit 47e77640be
    Date:   Thu Jul 20 18:28:01 2017 +0100

        Make language_def O(1)

the existing (if pointless) check of the la_magic field was removed.

There now appears to be no use of the la_magic field, and I propose
that we delete it.

There should be no user visible changes after this commit.

gdb/ChangeLog:

	* ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
	* c-lang.c (c_language_defn): Likewise.
	(cplus_language_defn): Likewise.
	(asm_language_defn): Likewise.
	(minimal_language_defn): Likewise.
	* d-lang.c (d_language_defn): Likewise.
	* f-lang.c (f_language_defn): Likewise.
	* go-lang.c (go_language_defn): Likewise.
	* language.c (unknown_language_defn): Likewise.
	(auto_language_defn): Likewise.
	* language.h (struct language_defn): Remove la_magic field.
	(LANG_MAGIC): Delete.
	* m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
	* objc-lang.c (objc_language_defn): Likewise.
	* opencl-lang.c (opencl_language_defn): Likewise.
	* p-lang.c (pascal_language_defn): Likewise.
	* rust-lang.c (rust_language_defn): Likewise.
This commit is contained in:
Andrew Burgess 2019-04-11 23:51:48 +01:00
parent 3822612df0
commit 62253a6147
13 changed files with 35 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

20
gdb/ChangeLog
View file

@ -1,3 +1,23 @@
2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
* ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
* c-lang.c (c_language_defn): Likewise.
(cplus_language_defn): Likewise.
(asm_language_defn): Likewise.
(minimal_language_defn): Likewise.
* d-lang.c (d_language_defn): Likewise.
* f-lang.c (f_language_defn): Likewise.
* go-lang.c (go_language_defn): Likewise.
* language.c (unknown_language_defn): Likewise.
(auto_language_defn): Likewise.
* language.h (struct language_defn): Remove la_magic field.
(LANG_MAGIC): Delete.
* m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
* objc-lang.c (objc_language_defn): Likewise.
* opencl-lang.c (opencl_language_defn): Likewise.
* p-lang.c (pascal_language_defn): Likewise.
* rust-lang.c (rust_language_defn): Likewise.
2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
* riscv-tdep.c (riscv_type_align): New function.

3
gdb/ada-lang.c
View file

@ -14380,8 +14380,7 @@ extern const struct language_defn ada_language_defn = {
default_search_name_hash,
&ada_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};
/* Command-list for the "set/show ada" prefix command. */

12
gdb/c-lang.c
View file

@ -873,8 +873,7 @@ extern const struct language_defn c_language_defn =
default_search_name_hash,
&c_varobj_ops,
c_get_compile_context,
c_compute_program,
LANG_MAGIC
c_compute_program
};
enum cplus_primitive_types {
@ -1018,8 +1017,7 @@ extern const struct language_defn cplus_language_defn =
cp_search_name_hash,
&cplus_varobj_ops,
cplus_get_compile_context,
cplus_compute_program,
LANG_MAGIC
cplus_compute_program
};
static const char *asm_extensions[] =
@ -1072,8 +1070,7 @@ extern const struct language_defn asm_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};
/* The following language_defn does not represent a real language.
@ -1126,6 +1123,5 @@ extern const struct language_defn minimal_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};

3
gdb/d-lang.c
View file

@ -250,8 +250,7 @@ extern const struct language_defn d_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};
/* Build all D language types for the specified architecture. */

3
gdb/f-lang.c
View file

@ -377,8 +377,7 @@ extern const struct language_defn f_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};
static void *

3
gdb/go-lang.c
View file

@ -611,8 +611,7 @@ extern const struct language_defn go_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};
static void *

6
gdb/language.c
View file

@ -876,8 +876,7 @@ const struct language_defn unknown_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};
/* These two structs define fake entries for the "local" and "auto"
@ -927,8 +926,7 @@ const struct language_defn auto_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};

8
gdb/language.h
View file

@ -449,16 +449,8 @@ struct language_defn
struct gdbarch *gdbarch,
const struct block *expr_block,
CORE_ADDR expr_pc);
/* Add fields above this point, so the magic number is always last. */
/* Magic number for compat checking. */
long la_magic;
};
#define LANG_MAGIC 910823L
/* Pointer to the language_defn for our current language. This pointer
always points to *some* valid struct; it can be used without checking
it for validity.

3
gdb/m2-lang.c
View file

@ -398,8 +398,7 @@ extern const struct language_defn m2_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};
static void *

3
gdb/objc-lang.c
View file

@ -408,8 +408,7 @@ extern const struct language_defn objc_language_defn = {
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};
/*

3
gdb/opencl-lang.c
View file

@ -1086,8 +1086,7 @@ extern const struct language_defn opencl_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};
static void *

3
gdb/p-lang.c
View file

@ -459,6 +459,5 @@ extern const struct language_defn pascal_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};

3
gdb/rust-lang.c
View file

@ -2141,6 +2141,5 @@ extern const struct language_defn rust_language_defn =
default_search_name_hash,
&default_varobj_ops,
NULL,
NULL,
LANG_MAGIC
NULL
};