* valops.c (find_overload_match): Call do_cleanups before early

return.
	* top.c (execute_command): Call do_cleanups before early return.
	(command_loop): Likewise.
	* stack.c (backtrace_command): Make a null cleanup early.  Don't
	conditionally call do_cleanups.
	* python/py-value.c (TRY_CATCH): Move cleanup handling into
	TRY_CATCH.
	* python/py-breakpoint.c (gdbpy_breakpoint_has_py_cond): Rearrange
	so cleanups are always run.
	* mi/mi-cmd-var.c (mi_cmd_var_delete): Reset old_cleanups.
	* findcmd.c (parse_find_args): Call do_cleanups on early return
	path.
	* dbxread.c (elfstab_build_psymtabs): Make a null cleanup early.
	Don't conditionally call do_cleanups.
	* cli/cli-script.c (execute_user_command): Initialize 'old_chain'
	later.
This commit is contained in:
Tom Tromey 2011-06-27 19:21:51 +00:00
parent 57eb9b5086
commit 5fe41fbfa2
10 changed files with 46 additions and 23 deletions

View file

@ -1425,7 +1425,7 @@ backtrace_command_stub (void *data)
static void
backtrace_command (char *arg, int from_tty)
{
struct cleanup *old_chain = NULL;
struct cleanup *old_chain = make_cleanup (null_cleanup, NULL);
int fulltrace_arg = -1, arglen = 0, argc = 0;
struct backtrace_command_args btargs;
@ -1435,7 +1435,7 @@ backtrace_command (char *arg, int from_tty)
int i;
argv = gdb_buildargv (arg);
old_chain = make_cleanup_freeargv (argv);
make_cleanup_freeargv (argv);
argc = 0;
for (i = 0; argv[i]; i++)
{
@ -1481,8 +1481,7 @@ backtrace_command (char *arg, int from_tty)
if (fulltrace_arg >= 0 && arglen > 0)
xfree (arg);
if (old_chain)
do_cleanups (old_chain);
do_cleanups (old_chain);
}
static void