FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Ada value printing on PPC64

Browse source 
The val_print removal patches introduced an Ada regression on PPC64
(probably any big-endian system).

The issue comes because value_field does not understand that Ada
wrapper fields can be bitfields that wrap a non-scalar type.  In this
case the value is already left-justified, so the justification done
there does the wrong thing.

Perhaps it would be good, eventually, to change value_field to
understand this case.  In the meantime this implements an Ada-specific
solution.

gdb/ChangeLog
2020-05-11  Tom Tromey  <tromey@adacore.com>

	* ada-lang.c (ada_value_primitive_field): Now public.
	* ada-lang.h (ada_value_primitive_field): Declare.
	* ada-valprint.c (print_field_values): Use
	ada_value_primitive_field for wrapper fields.
This commit is contained in:
Tom Tromey 2020-05-11 14:57:49 -06:00
parent e000211765
commit 5eb68a39a2
4 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/ada-lang.h
View file

@ -234,6 +234,11 @@ extern struct bound_minimal_symbol ada_lookup_simple_minsym (const char *);
extern int ada_scan_number (const char *, int, LONGEST *, int *);
extern struct value *ada_value_primitive_field (struct value *arg1,
int offset,
int fieldno,
struct type *arg_type);
extern struct type *ada_parent_type (struct type *);
extern int ada_is_ignored_field (struct type *, int);