FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

binutils, ld: dequote libctf error messages

Browse source 
These are not identifiers and should not be quoted.  (Also, quoting them
just looks odd.)

Adjust diagnostics tests accordingly.

binutils/ChangeLog
2020-08-27  Nick Alcock  <nick.alcock@oracle.com>

	* objdump.c (dump_ctf_errs): Unquote CTF error messages.
	* readelf.c (dump_ctf_errs): Likewise.

ld/ChangeLog
2020-08-27  Nick Alcock  <nick.alcock@oracle.com>

	* ldlang.c (dump_ctf_errs): Unquote CTF error messages.
	(ldlang_open_ctf): Likewise.
	(lang_merge_ctf): Likewise.
	(lang_write_ctf): Likewise.
	* testsuite/ld-ctf/diag-ctf-version-f.d: Adjust.
	* testsuite/ld-ctf/diag-cttname-invalid.d: Adjust.
	* testsuite/ld-ctf/diag-decompression-failure.d: Adjust.
	* testsuite/ld-ctf/diag-parname.d: Adjust.
	* testsuite/ld-ctf/diag-unsupported-flag.d: Adjust.
	* testsuite/ld-ctf/diag-wrong-magic-number-mixed.d: Adjust.
	* testsuite/ld-ctf/diag-wrong-magic-number.d: Adjust.
This commit is contained in:
Nick Alcock 2020-07-29 13:50:10 +01:00
parent 926c9e7665
commit 5e9b84f7a2
12 changed files with 32 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ld/ldlang.c
View file

@ -3683,7 +3683,7 @@ lang_ctf_errs_warnings (ctf_file_t *fp)
while ((text = ctf_errwarning_next (fp, &i, &is_warning, &err)) != NULL)
{
einfo (_("%s: `%s'\n"), is_warning ? _("CTF warning"): _("CTF error"),
einfo (_("%s: %s\n"), is_warning ? _("CTF warning"): _("CTF error"),
text);
free (text);
}
@ -3724,7 +3724,7 @@ ldlang_open_ctf (void)
{
lang_ctf_errs_warnings (NULL);
einfo (_("%P: warning: CTF section in %pB not loaded; "
"its types will be discarded: `%s'\n"), file->the_bfd,
"its types will be discarded: %s\n"), file->the_bfd,
ctf_errmsg (err));
}
continue;
@ -3814,7 +3814,7 @@ lang_merge_ctf (void)
{
lang_ctf_errs_warnings (ctf_output);
einfo (_("%P: warning: CTF linking failed; "
"output will have no CTF section: `%s'\n"),
"output will have no CTF section: %s\n"),
ctf_errmsg (ctf_errno (ctf_output)));
if (output_sect)
{
@ -3874,7 +3874,7 @@ lang_write_ctf (int late)
if (!output_sect->contents)
{
einfo (_("%P: warning: CTF section emission failed; "
"output will have no CTF section: `%s'\n"),
"output will have no CTF section: %s\n"),
ctf_errmsg (ctf_errno (ctf_output)));
output_sect->size = 0;
output_sect->flags |= SEC_EXCLUDE;