FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

binutils, ld: dequote libctf error messages

Browse source 
These are not identifiers and should not be quoted.  (Also, quoting them
just looks odd.)

Adjust diagnostics tests accordingly.

binutils/ChangeLog
2020-08-27  Nick Alcock  <nick.alcock@oracle.com>

	* objdump.c (dump_ctf_errs): Unquote CTF error messages.
	* readelf.c (dump_ctf_errs): Likewise.

ld/ChangeLog
2020-08-27  Nick Alcock  <nick.alcock@oracle.com>

	* ldlang.c (dump_ctf_errs): Unquote CTF error messages.
	(ldlang_open_ctf): Likewise.
	(lang_merge_ctf): Likewise.
	(lang_write_ctf): Likewise.
	* testsuite/ld-ctf/diag-ctf-version-f.d: Adjust.
	* testsuite/ld-ctf/diag-cttname-invalid.d: Adjust.
	* testsuite/ld-ctf/diag-decompression-failure.d: Adjust.
	* testsuite/ld-ctf/diag-parname.d: Adjust.
	* testsuite/ld-ctf/diag-unsupported-flag.d: Adjust.
	* testsuite/ld-ctf/diag-wrong-magic-number-mixed.d: Adjust.
	* testsuite/ld-ctf/diag-wrong-magic-number.d: Adjust.
This commit is contained in:
Nick Alcock 2020-07-29 13:50:10 +01:00
parent 926c9e7665
commit 5e9b84f7a2
12 changed files with 32 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
binutils/objdump.c
View file

@ -4083,7 +4083,7 @@ dump_ctf_errs (ctf_file_t *fp)
/* Dump accumulated errors and warnings. */
while ((errtext = ctf_errwarning_next (fp, &it, &is_warning, &err)) != NULL)
{
non_fatal (_("%s: `%s'"), is_warning ? _("warning"): _("error"),
non_fatal (_("%s: %s"), is_warning ? _("warning"): _("error"),
errtext);
free (errtext);
}