FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not expose stub types to Python

Browse source 
dwarf2read.c will create stub types for Ada "Taft Amendment" types.
These stub types can currently be exposed to Python code, where they
show up as TYPE_CODE_VOID types (but that, mysteriously, can sometimes
be used in other ways).

While it's possible to work with such types by using strip_typedefs,
this seemed unpleasant to me.  This patch takes another approach
instead, which is to try not to expose stub types to Python users.

gdb/ChangeLog
2019-09-26  Tom Tromey  <tromey@adacore.com>

	* python/py-type.c (type_to_type_object): Call check_typedef
	for stub types.

gdb/testsuite/ChangeLog
2019-09-26  Tom Tromey  <tromey@adacore.com>

	* gdb.ada/py_taft.exp: New file.
	* gdb.ada/py_taft/main.adb: New file.
	* gdb.ada/py_taft/pkg.adb: New file.
	* gdb.ada/py_taft/pkg.ads: New file.
This commit is contained in:
Tom Tromey 2019-08-19 13:41:34 -06:00
parent 12904d3729
commit 5d63b30afa
7 changed files with 132 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
gdb/python/py-type.c
View file

@ -1334,6 +1334,17 @@ type_to_type_object (struct type *type)
{
type_object *type_obj;
try
{
/* Try not to let stub types leak out to Python. */
if (TYPE_STUB (type))
type = check_typedef (type);
}
catch (...)
{
/* Just ignore failures in check_typedef. */
}
type_obj = PyObject_New (type_object, &type_object_type);
if (type_obj)
set_type (type_obj, type);