FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

reloc_upper_bound size calculations

Browse source 
Section reloc_count is an unsigned int.  Adding one for a NULL
terminator to an array of arelent pointers can wrap the count to
zero.  Avoid that by doing the addition as longs.

	* coffgen.c (coff_get_reloc_upper_bound): Don't overflow unsigned
	int expression.
	* elf.c (_bfd_elf_get_reloc_upper_bound): Likewise.
	* elf64-sparc.c (elf64_sparc_get_reloc_upper_bound): Likewise.
	* mach-o.c (bfd_mach_o_get_reloc_upper_bound): Likewise.
	* vms-alpha.c (alpha_vms_get_reloc_upper_bound): Likewise.
This commit is contained in:
Alan Modra 2021-07-30 12:58:12 +09:30
parent 472dd8b357
commit 5cfe19e51e
5 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
bfd/coffgen.c
View file

@ -1996,7 +1996,7 @@ coff_get_reloc_upper_bound (bfd *abfd, sec_ptr asect)
return -1;
}
#endif
return (asect->reloc_count + 1) * sizeof (arelent *);
return (asect->reloc_count + 1L) * sizeof (arelent *);
}
asymbol *

2
bfd/elf.c
View file

@ -8559,7 +8559,7 @@ _bfd_elf_get_reloc_upper_bound (bfd *abfd, sec_ptr asect)
return -1;
}
#endif
return (asect->reloc_count + 1) * sizeof (arelent *);
return (asect->reloc_count + 1L) * sizeof (arelent *);
}
/* Canonicalize the relocs. */

2
bfd/elf64-sparc.c
View file

@ -44,7 +44,7 @@ elf64_sparc_get_reloc_upper_bound (bfd *abfd ATTRIBUTE_UNUSED, asection *sec)
return -1;
}
#endif
return (sec->reloc_count * 2 + 1) * sizeof (arelent *);
return (sec->reloc_count * 2L + 1) * sizeof (arelent *);
}
static long

2
bfd/mach-o.c
View file

@ -1427,7 +1427,7 @@ bfd_mach_o_get_reloc_upper_bound (bfd *abfd ATTRIBUTE_UNUSED,
return -1;
}
#endif
return (asect->reloc_count + 1) * sizeof (arelent *);
return (asect->reloc_count + 1L) * sizeof (arelent *);
}
/* In addition to the need to byte-swap the symbol number, the bit positions

2
bfd/vms-alpha.c
View file

@ -5443,7 +5443,7 @@ alpha_vms_get_reloc_upper_bound (bfd *abfd ATTRIBUTE_UNUSED, asection *section)
{
alpha_vms_slurp_relocs (abfd);
return (section->reloc_count + 1) * sizeof (arelent *);
return (section->reloc_count + 1L) * sizeof (arelent *);
}
/* Convert relocations from VMS (external) form into BFD internal