FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove ALL_COMPUNIT_FILETABS

Browse source 
This removes ALL_COMPUNIT_FILETABS, replacing its uses with ranged for
loops.

Because this is still used in the ALL_OBJFILE_FILETABS macro, in some
places a declaration had to be removed or renamed to avoid shadowing.

gdb/ChangeLog
2019-01-09  Tom Tromey  <tom@tromey.com>

	* symtab.h (ALL_COMPUNIT_FILETABS): Remove.
	(compunit_filetabs): New.
	* symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
	compunit_filetabs.
	(info_sources_command, make_source_files_completion_list): Remove
	declaration.
	* symmisc.c (print_objfile_statistics, dump_objfile)
	(maintenance_print_symbols): Remove declaration.
	(maintenance_info_symtabs): Use compunit_filetabs.
	(maintenance_info_line_tables): Likewise.
	* source.c (select_source_symtab): Change local variable name.
	(forget_cached_source_info_for_objfile): Remove declaration.
	* objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
	* objfiles.c (objfile_relocate1): Remove declaration.
	* mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
	declaration.
	* maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
	* coffread.c (coff_symtab_read): Remove declaration.
	* buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
	compunit_filetabs.
This commit is contained in:
Tom Tromey 2018-11-24 09:49:24 -07:00
parent d8aeb77f04
commit 5accd1a07e
11 changed files with 52 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

13
gdb/symtab.h
View file

@ -29,6 +29,7 @@
#include "common/enum-flags.h"
#include "common/function-view.h"
#include "common/gdb_optional.h"
#include "common/next-iterator.h"
#include "completer.h"
/* Opaque declarations. */
@ -1485,10 +1486,16 @@ struct compunit_symtab
#define COMPUNIT_CALL_SITE_HTAB(cust) ((cust)->call_site_htab)
#define COMPUNIT_MACRO_TABLE(cust) ((cust)->macro_table)
/* Iterate over all file tables (struct symtab) within a compunit. */
/* A range adapter to allowing iterating over all the file tables
within a compunit. */
#define ALL_COMPUNIT_FILETABS(cu, s) \
for ((s) = (cu) -> filetabs; (s) != NULL; (s) = (s) -> next)
struct compunit_filetabs : public next_adapter<struct symtab>
{
compunit_filetabs (struct compunit_symtab *cu)
: next_adapter<struct symtab> (cu->filetabs)
{
}
};
/* Return the primary symtab of CUST. */