gdb: make target_desc_info_from_user_p a method of target_desc_info

Move the implementation over to target_desc_info.  Remove the
target_desc_info forward declaration in target-descriptions.h, it's no
longer needed.

Change-Id: Ic95060341685afe0b73af591ca6efe32f5e7e892
This commit is contained in:
Simon Marchi 2023-02-03 09:21:26 -05:00 committed by Simon Marchi
parent 5776836631
commit 5a19bfd673
4 changed files with 6 additions and 17 deletions

View file

@ -961,7 +961,7 @@ clone_inferior_command (const char *args, int from_tty)
/* If the original inferior had a user specified target
description, make the clone use it too. */
if (target_desc_info_from_user_p (&inf->tdesc_info))
if (inf->tdesc_info.from_user_p ())
inf->tdesc_info = orginf->tdesc_info;
clone_program_space (pspace, orginf->pspace);

View file

@ -345,6 +345,11 @@ extern void switch_to_inferior_no_thread (inferior *inf);
struct target_desc_info
{
/* Returns true if INFO indicates the target description had been supplied by
the user. */
bool from_user_p ()
{ return !this->filename.empty (); }
/* A flag indicating that a description has already been fetched
from the target, so it should not be queried again. */
bool fetched = false;

View file

@ -451,14 +451,6 @@ get_arch_data (struct gdbarch *gdbarch)
return result;
}
/* See target-descriptions.h. */
int
target_desc_info_from_user_p (struct target_desc_info *info)
{
return info != nullptr && !info->filename.empty ();
}
/* The string manipulated by the "set tdesc filename ..." command. */
static std::string tdesc_filename_cmd_string;

View file

@ -26,9 +26,6 @@
struct tdesc_arch_data;
struct target_ops;
/* An inferior's target description info is stored in this opaque
object. There's one such object per inferior. */
struct target_desc_info;
struct inferior;
/* Fetch the current inferior's description, and switch its current
@ -48,11 +45,6 @@ void target_clear_description (void);
const struct target_desc *target_current_description (void);
/* Returns true if INFO indicates the target description had been
supplied by the user. */
int target_desc_info_from_user_p (struct target_desc_info *info);
/* Record architecture-specific functions to call for pseudo-register
support. If tdesc_use_registers is called and gdbarch_num_pseudo_regs
is greater than zero, then these should be called as well.