FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix macOS null pointer dereference

Browse source 
<https://sourceware.org/bugzilla/show_bug.cgi?id=22960#c4> reports
that macOS gdb crashes with a null pointer dereference in
push_target(struct target_ops *).  This commit fixes that.

The problem is that commit f6ac5f3d63 ("Convert struct target_ops to
C++") left the darwin_ops global uninitialized.

We don't need that global anymore, we can use the (new)
get_native_target function instead for the same effect.

gdb/ChangeLog:
2018-06-04  Pedro Alves  <palves@redhat.com>

	* darwin-nat.c (darwin_ops): Delete.
	(darwin_attach_pid): Use get_native_target.
This commit is contained in:
Pedro Alves 2018-06-04 12:26:39 +01:00
parent 1332a14001
commit 59f413d541
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2018-06-04 Pedro Alves <palves@redhat.com>
* darwin-nat.c (darwin_ops): Delete.
(darwin_attach_pid): Use get_native_target.
2018-06-04 Alan Hayward <alan.hayward@arm.com>
* aarch64-tdep.c (aarch64_get_tdesc_vq): Use uint64_t for VQ.

4
gdb/darwin-nat.c
View file

@ -97,9 +97,6 @@ static void darwin_deallocate_exception_ports (darwin_inferior *inf);
static void darwin_setup_exceptions (struct inferior *inf);
static void darwin_deallocate_threads (struct inferior *inf);
/* Target operations for Darwin. */
static struct target_ops *darwin_ops;
/* Task identifier of gdb. */
static task_t gdb_task;
@ -1656,6 +1653,7 @@ darwin_attach_pid (struct inferior *inf)
darwin_setup_exceptions (inf);
target_ops *darwin_ops = get_native_target ();
if (!target_is_pushed (darwin_ops))
push_target (darwin_ops);
}