FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: make get_array_bounds return bool

Browse source 
Obvious change from int to bool.  I took the opportunity to move the doc
to the header file.

gdb/ChangeLog:

	* gdbtypes.h (get_array_bounds): Return bool, adjust some
	callers.  Move doc here.
	* gdbtypes.c (get_array_bounds): Return bool

Change-Id: I8ed20298cb0927963c1f09b345966533d5ed06e2
This commit is contained in:
Simon Marchi 2020-11-17 17:53:27 -05:00
parent 3d955acb36
commit 584903d3f5
5 changed files with 22 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2020-11-17 Simon Marchi <simon.marchi@polymtl.ca>
* gdbtypes.h (get_array_bounds): Return bool, adjust some
callers. Move doc here.
* gdbtypes.c (get_array_bounds): Return bool
2020-11-17 Andrew Burgess <andrew.burgess@embecosm.com>
* arc-linux-tdep.c (arc_linux_sw_breakpoint_from_kind): Add an

2
gdb/compile/compile-c-types.c
View file

@ -70,7 +70,7 @@ convert_array (compile_c_instance *context, struct type *type)
{
LONGEST low_bound, high_bound, count;
if (get_array_bounds (type, &low_bound, &high_bound) == 0)
if (!get_array_bounds (type, &low_bound, &high_bound))
count = -1;
else
{

2
gdb/compile/compile-cplus-types.c
View file

@ -491,7 +491,7 @@ compile_cplus_convert_array (compile_cplus_instance *instance,
{
LONGEST low_bound, high_bound, count;
if (get_array_bounds (type, &low_bound, &high_bound) == 0)
if (!get_array_bounds (type, &low_bound, &high_bound))
count = -1;
else
{

15
gdb/gdbtypes.c
View file

@ -1119,14 +1119,9 @@ get_discrete_bounds (struct type *type, LONGEST *lowp, LONGEST *highp)
}
}
/* Assuming TYPE is a simple, non-empty array type, compute its upper
and lower bound. Save the low bound into LOW_BOUND if not NULL.
Save the high bound into HIGH_BOUND if not NULL.
/* See gdbtypes.h */
Return 1 if the operation was successful. Return zero otherwise,
in which case the values of LOW_BOUND and HIGH_BOUNDS are unmodified. */
int
bool
get_array_bounds (struct type *type, LONGEST *low_bound, LONGEST *high_bound)
{
struct type *index = type->index_type ();
@ -1135,11 +1130,11 @@ get_array_bounds (struct type *type, LONGEST *low_bound, LONGEST *high_bound)
int res;
if (index == NULL)
return 0;
return false;
res = get_discrete_bounds (index, &low, &high);
if (res == -1)
return 0;
return false;
if (low_bound)
*low_bound = low;
@ -1147,7 +1142,7 @@ get_array_bounds (struct type *type, LONGEST *low_bound, LONGEST *high_bound)
if (high_bound)
*high_bound = high;
return 1;
return true;
}
/* Assuming that TYPE is a discrete type and VAL is a valid integer

9
gdb/gdbtypes.h
View file

@ -2435,7 +2435,14 @@ extern int get_vptr_fieldno (struct type *, struct type **);
extern int get_discrete_bounds (struct type *, LONGEST *, LONGEST *);
extern int get_array_bounds (struct type *type, LONGEST *low_bound,
/* Assuming TYPE is a simple, non-empty array type, compute its upper
and lower bound. Save the low bound into LOW_BOUND if not NULL.
Save the high bound into HIGH_BOUND if not NULL.
Return true if the operation was successful. Return false otherwise,
in which case the values of LOW_BOUND and HIGH_BOUNDS are unmodified. */
extern bool get_array_bounds (struct type *type, LONGEST *low_bound,
LONGEST *high_bound);
extern int discrete_position (struct type *type, LONGEST val, LONGEST *pos);