target_ops: Use bool throughout

After the previous target_ops/C++ patches are all squashed and merged,
this one can go in separately.

This patch adjusts all the target methods to return bool instead of int
when they're returning a boolean.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* target.h (target_ops)
	<stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
	stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
	stopped_by_watchpoint, have_continuable_watchpoint,
	stopped_data_address, watchpoint_addr_within_range,
	can_accel_watchpoint_condition, can_run, thread_alive,
	has_all_memory, has_memory, has_stack, has_registers,
	has_execution, can_async_p, is_async_p, supports_non_stop,
	always_non_stop_p, can_execute_reverse, supports_multi_process,
	supports_enable_disable_tracepoint,
	supports_disable_randomization, supports_string_tracing,
	supports_evaluation_of_breakpoint_conditions,
	can_run_breakpoint_commands, filesystem_is_local,
	can_download_tracepoint, get_trace_state_variable_value,
	set_trace_notes, get_tib_address, use_agent, can_use_agent,
	record_is_replaying, record_will_replay,
	augmented_libraries_svr4_read>: Adjust to return bool.
	* aarch64-linux-nat.c: All implementations adjusted.
	* aix-thread.c: All implementations adjusted.
	* arm-linux-nat.c: All implementations adjusted.
	* breakpoint.c: All implementations adjusted.
	* bsd-kvm.c: All implementations adjusted.
	* bsd-uthread.c: All implementations adjusted.
	* corelow.c: All implementations adjusted.
	* ctf.c: All implementations adjusted.
	* darwin-nat.c: All implementations adjusted.
	* darwin-nat.h: All implementations adjusted.
	* exec.c: All implementations adjusted.
	* fbsd-nat.c: All implementations adjusted.
	* fbsd-nat.h: All implementations adjusted.
	* gnu-nat.c: All implementations adjusted.
	* gnu-nat.h: All implementations adjusted.
	* go32-nat.c: All implementations adjusted.
	* ia64-linux-nat.c: All implementations adjusted.
	* inf-child.c: All implementations adjusted.
	* inf-child.h: All implementations adjusted.
	* inf-ptrace.c: All implementations adjusted.
	* inf-ptrace.h: All implementations adjusted.
	* linux-nat.c: All implementations adjusted.
	* linux-nat.h: All implementations adjusted.
	* mips-linux-nat.c: All implementations adjusted.
	* nto-procfs.c: All implementations adjusted.
	* ppc-linux-nat.c: All implementations adjusted.
	* procfs.c: All implementations adjusted.
	* ravenscar-thread.c: All implementations adjusted.
	* record-btrace.c: All implementations adjusted.
	* record-full.c: All implementations adjusted.
	* remote-sim.c: All implementations adjusted.
	* remote.c: All implementations adjusted.
	* s390-linux-nat.c: All implementations adjusted.
	* sol-thread.c: All implementations adjusted.
	* spu-multiarch.c: All implementations adjusted.
	* target-delegates.c: All implementations adjusted.
	* target.c: All implementations adjusted.
	* target.h: All implementations adjusted.
	* tracefile-tfile.c: All implementations adjusted.
	* tracefile.c: All implementations adjusted.
	* tracefile.h: All implementations adjusted.
	* windows-nat.c: All implementations adjusted.
	* x86-linux-nat.h: All implementations adjusted.
	* x86-nat.h: All implementations adjusted.
This commit is contained in:
Pedro Alves 2018-05-03 00:37:26 +01:00
parent ad6a4e2dd6
commit 57810aa7e8
47 changed files with 772 additions and 708 deletions

View file

@ -227,16 +227,16 @@ public:
void close () override;
void async (int) override;
ptid_t wait (ptid_t, struct target_waitstatus *, int) override;
int stopped_by_watchpoint () override;
int stopped_data_address (CORE_ADDR *) override;
bool stopped_by_watchpoint () override;
bool stopped_data_address (CORE_ADDR *) override;
int stopped_by_sw_breakpoint () override;
int supports_stopped_by_sw_breakpoint () override;
bool stopped_by_sw_breakpoint () override;
bool supports_stopped_by_sw_breakpoint () override;
int stopped_by_hw_breakpoint () override;
int supports_stopped_by_hw_breakpoint () override;
bool stopped_by_hw_breakpoint () override;
bool supports_stopped_by_hw_breakpoint () override;
int can_execute_reverse () override;
bool can_execute_reverse () override;
/* Add bookmark target methods. */
gdb_byte *get_bookmark (const char *, int) override;
@ -247,8 +247,8 @@ public:
void save_record (const char *filename) override;
bool supports_delete_record () override;
void delete_record () override;
int record_is_replaying (ptid_t ptid) override;
int record_will_replay (ptid_t ptid, int dir) override;
bool record_is_replaying (ptid_t ptid) override;
bool record_will_replay (ptid_t ptid, int dir) override;
void record_stop_replaying () override;
void goto_record_begin () override;
void goto_record_end () override;
@ -309,7 +309,7 @@ public:
struct bp_target_info *,
enum remove_bp_reason) override;
int has_execution (ptid_t) override;
bool has_execution (ptid_t) override;
};
static record_full_target record_full_ops;
@ -1463,7 +1463,7 @@ record_full_base_target::wait (ptid_t ptid, struct target_waitstatus *status,
return return_ptid;
}
int
bool
record_full_base_target::stopped_by_watchpoint ()
{
if (RECORD_FULL_IS_REPLAY)
@ -1472,18 +1472,18 @@ record_full_base_target::stopped_by_watchpoint ()
return beneath->stopped_by_watchpoint ();
}
int
bool
record_full_base_target::stopped_data_address (CORE_ADDR *addr_p)
{
if (RECORD_FULL_IS_REPLAY)
return 0;
return false;
else
return this->beneath->stopped_data_address (addr_p);
}
/* The stopped_by_sw_breakpoint method of target record-full. */
int
bool
record_full_base_target::stopped_by_sw_breakpoint ()
{
return record_full_stop_reason == TARGET_STOPPED_BY_SW_BREAKPOINT;
@ -1492,15 +1492,15 @@ record_full_base_target::stopped_by_sw_breakpoint ()
/* The supports_stopped_by_sw_breakpoint method of target
record-full. */
int
bool
record_full_base_target::supports_stopped_by_sw_breakpoint ()
{
return 1;
return true;
}
/* The stopped_by_hw_breakpoint method of target record-full. */
int
bool
record_full_base_target::stopped_by_hw_breakpoint ()
{
return record_full_stop_reason == TARGET_STOPPED_BY_HW_BREAKPOINT;
@ -1509,10 +1509,10 @@ record_full_base_target::stopped_by_hw_breakpoint ()
/* The supports_stopped_by_sw_breakpoint method of target
record-full. */
int
bool
record_full_base_target::supports_stopped_by_hw_breakpoint ()
{
return 1;
return true;
}
/* Record registers change (by user or by GDB) to list as an instruction. */
@ -1834,10 +1834,10 @@ record_full_target::remove_breakpoint (struct gdbarch *gdbarch,
/* "can_execute_reverse" method for process record target. */
int
bool
record_full_base_target::can_execute_reverse ()
{
return 1;
return true;
}
/* "get_bookmark" method for process record and prec over core. */
@ -1962,7 +1962,7 @@ record_full_base_target::delete_record ()
/* The "record_is_replaying" target method. */
int
bool
record_full_base_target::record_is_replaying (ptid_t ptid)
{
return RECORD_FULL_IS_REPLAY;
@ -1970,7 +1970,7 @@ record_full_base_target::record_is_replaying (ptid_t ptid)
/* The "record_will_replay" target method. */
int
bool
record_full_base_target::record_will_replay (ptid_t ptid, int dir)
{
/* We can currently only record when executing forwards. Should we be able
@ -2240,10 +2240,10 @@ record_full_core_target::remove_breakpoint (struct gdbarch *gdbarch,
/* "has_execution" method for prec over corefile. */
int
bool
record_full_core_target::has_execution (ptid_t the_ptid)
{
return 1;
return true;
}
/* Record log save-file format