FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use filtered output in *-tdep commands

Browse source 
Various targets introduce their own commands, which then use
unfiltered output.  It's better to use filtered output by default, so
this patch fixes the instances I found.
This commit is contained in:
Tom Tromey 2021-12-24 22:15:42 -07:00
parent 7f762abff6
commit 56c5b29b61
5 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gdb/avr-tdep.c
View file

@ -1589,7 +1589,7 @@ avr_io_reg_read_command (const char *args, int from_tty)
return; return;
} }
printf_unfiltered (_("Target has %u io registers:\n\n"), nreg); printf_filtered (_("Target has %u io registers:\n\n"), nreg);
/* only fetch up to 8 registers at a time to keep the buffer small */ /* only fetch up to 8 registers at a time to keep the buffer small */
int step = 8; int step = 8;

30
gdb/hppa-tdep.c
View file

@ -2572,19 +2572,19 @@ unwind_command (const char *exp, int from_tty)
if (!u) if (!u)
{ {
printf_unfiltered ("Can't find unwind table entry for %s\n", exp); printf_filtered ("Can't find unwind table entry for %s\n", exp);
return; return;
} }
printf_unfiltered ("unwind_table_entry (%s):\n", host_address_to_string (u)); printf_filtered ("unwind_table_entry (%s):\n", host_address_to_string (u));
printf_unfiltered ("\tregion_start = %s\n", hex_string (u->region_start)); printf_filtered ("\tregion_start = %s\n", hex_string (u->region_start));
printf_unfiltered ("\tregion_end = %s\n", hex_string (u->region_end)); printf_filtered ("\tregion_end = %s\n", hex_string (u->region_end));
#define pif(FLD) if (u->FLD) printf_unfiltered (" "#FLD); #define pif(FLD) if (u->FLD) printf_filtered (" "#FLD);
printf_unfiltered ("\n\tflags ="); printf_filtered ("\n\tflags =");
pif (Cannot_unwind); pif (Cannot_unwind);
pif (Millicode); pif (Millicode);
pif (Millicode_save_sr0); pif (Millicode_save_sr0);
@ -2609,9 +2609,9 @@ unwind_command (const char *exp, int from_tty)
pif (Large_frame); pif (Large_frame);
pif (alloca_frame); pif (alloca_frame);
putchar_unfiltered ('\n'); putchar_filtered ('\n');
#define pin(FLD) printf_unfiltered ("\t"#FLD" = 0x%x\n", u->FLD); #define pin(FLD) printf_filtered ("\t"#FLD" = 0x%x\n", u->FLD);
pin (Region_description); pin (Region_description);
pin (Entry_FR); pin (Entry_FR);
@ -2620,26 +2620,26 @@ unwind_command (const char *exp, int from_tty)
if (u->stub_unwind.stub_type) if (u->stub_unwind.stub_type)
{ {
printf_unfiltered ("\tstub type = "); printf_filtered ("\tstub type = ");
switch (u->stub_unwind.stub_type) switch (u->stub_unwind.stub_type)
{ {
case LONG_BRANCH: case LONG_BRANCH:
printf_unfiltered ("long branch\n"); printf_filtered ("long branch\n");
break; break;
case PARAMETER_RELOCATION: case PARAMETER_RELOCATION:
printf_unfiltered ("parameter relocation\n"); printf_filtered ("parameter relocation\n");
break; break;
case EXPORT: case EXPORT:
printf_unfiltered ("export\n"); printf_filtered ("export\n");
break; break;
case IMPORT: case IMPORT:
printf_unfiltered ("import\n"); printf_filtered ("import\n");
break; break;
case IMPORT_SHLIB: case IMPORT_SHLIB:
printf_unfiltered ("import shlib\n"); printf_filtered ("import shlib\n");
break; break;
default: default:
printf_unfiltered ("unknown (%d)\n", u->stub_unwind.stub_type); printf_filtered ("unknown (%d)\n", u->stub_unwind.stub_type);
} }
} }
} }

6
gdb/i386-tdep.c
View file

@ -8992,14 +8992,14 @@ i386_mpx_info_bounds (const char *args, int from_tty)
if (gdbarch_bfd_arch_info (gdbarch)->arch != bfd_arch_i386 if (gdbarch_bfd_arch_info (gdbarch)->arch != bfd_arch_i386
|| !i386_mpx_enabled ()) || !i386_mpx_enabled ())
{ {
printf_unfiltered (_("Intel Memory Protection Extensions not " printf_filtered (_("Intel Memory Protection Extensions not "
"supported on this target.\n")); "supported on this target.\n"));
return; return;
} }
if (args == NULL) if (args == NULL)
{ {
printf_unfiltered (_("Address of pointer variable expected.\n")); printf_filtered (_("Address of pointer variable expected.\n"));
return; return;
} }

6
gdb/mips-tdep.c
View file

@ -6916,7 +6916,7 @@ show_mipsfpu_command (const char *args, int from_tty)
if (gdbarch_bfd_arch_info (target_gdbarch ())->arch != bfd_arch_mips) if (gdbarch_bfd_arch_info (target_gdbarch ())->arch != bfd_arch_mips)
{ {
printf_unfiltered printf_filtered
("The MIPS floating-point coprocessor is unknown " ("The MIPS floating-point coprocessor is unknown "
"because the current architecture is not MIPS.\n"); "because the current architecture is not MIPS.\n");
return; return;
@ -6937,11 +6937,11 @@ show_mipsfpu_command (const char *args, int from_tty)
internal_error (__FILE__, __LINE__, _("bad switch")); internal_error (__FILE__, __LINE__, _("bad switch"));
} }
if (mips_fpu_type_auto) if (mips_fpu_type_auto)
printf_unfiltered ("The MIPS floating-point coprocessor " printf_filtered ("The MIPS floating-point coprocessor "
"is set automatically (currently %s)\n", "is set automatically (currently %s)\n",
fpu); fpu);
else else
printf_unfiltered printf_filtered
("The MIPS floating-point coprocessor is assumed to be %s\n", fpu); ("The MIPS floating-point coprocessor is assumed to be %s\n", fpu);
} }

2
gdb/s12z-tdep.c
View file

@ -635,7 +635,7 @@ show_bdccsr_command (const char *args, int from_tty)
struct string_file output; struct string_file output;
target_rcmd ("bdccsr", &output); target_rcmd ("bdccsr", &output);
printf_unfiltered ("The current BDCCSR value is %s\n", output.string().c_str()); printf_filtered ("The current BDCCSR value is %s\n", output.string().c_str());
} }
static struct gdbarch * static struct gdbarch *