FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix compiler warning in linux-namespaces.c

Browse source 
../../gdb/nat/linux-namespaces.c: In function ‘void mnsh_main(int)’:
../../gdb/nat/linux-namespaces.c:604:8: warning: ‘fd’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  close (fd);
  ~~~~~~^~~~

And the warning is correct -- mnsh_recv_message can return -1 and leave fd
uninitialized, and mnsh_main will still call close (fd) if that happens.

Initialize fd to -1 to avoid that.

gdb/ChangeLog:

2019-08-27  Christian Biesinger  <cbiesinger@google.com>

	* nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
This commit is contained in:
Christian Biesinger 2019-08-27 13:22:38 -05:00
parent ec1b0fbb8d
commit 550105b779
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gdb/ChangeLog
View file

@ -1,3 +1,7 @@
2019-08-27 Christian Biesinger <cbiesinger@google.com>
* nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
* cli/cli-utils.c (info_print_options_defs): Delete.

2
gdb/nat/linux-namespaces.c
View file

@ -562,7 +562,7 @@ mnsh_main (int sock)
while (1)
{
enum mnsh_msg_type type;
int fd, int1, int2;
int fd = -1, int1, int2;
char buf[PATH_MAX];
ssize_t size, response = -1;