fix record "run" regression
This fixes the record "run" regression pointed out by Marc Khouzam: https://sourceware.org/ml/gdb/2014-06/msg00096.html The bug is that target_require_runnable must agree with the handling of the "run" target, but currently it is out of sync. This patch fixes the problem by changing target_require_runnable to also ignore the record_stratum. Built and regtested on x86-64 Fedora 20. New test case included. 2014-07-14 Tom Tromey <tromey@redhat.com> * target.c (target_require_runnable): Also check record_stratum. Update comment. 2014-07-14 Tom Tromey <tromey@redhat.com> * gdb.reverse/rerun-prec.c: New file. * gdb.reverse/rerun-prec.exp: New file.
This commit is contained in:
parent
0ed82684ef
commit
548740d6bd
5 changed files with 68 additions and 1 deletions
|
@ -1,3 +1,8 @@
|
|||
2014-07-14 Tom Tromey <tromey@redhat.com>
|
||||
|
||||
* target.c (target_require_runnable): Also check record_stratum.
|
||||
Update comment.
|
||||
|
||||
2014-07-11 Yao Qi <yao@codesourcery.com>
|
||||
|
||||
* arm-tdep.c (thumb_analyze_prologue): Break the loop if
|
||||
|
|
|
@ -2425,10 +2425,11 @@ target_require_runnable (void)
|
|||
if (t->to_create_inferior != NULL)
|
||||
return;
|
||||
|
||||
/* Do not worry about thread_stratum targets that can not
|
||||
/* Do not worry about targets at certain strata that can not
|
||||
create inferiors. Assume they will be pushed again if
|
||||
necessary, and continue to the process_stratum. */
|
||||
if (t->to_stratum == thread_stratum
|
||||
|| t->to_stratum == record_stratum
|
||||
|| t->to_stratum == arch_stratum)
|
||||
continue;
|
||||
|
||||
|
|
|
@ -1,3 +1,8 @@
|
|||
2014-07-14 Tom Tromey <tromey@redhat.com>
|
||||
|
||||
* gdb.reverse/rerun-prec.c: New file.
|
||||
* gdb.reverse/rerun-prec.exp: New file.
|
||||
|
||||
2014-07-12 Maciej W. Rozycki <macro@mips.com>
|
||||
Maciej W. Rozycki <macro@codesourcery.com>
|
||||
|
||||
|
|
21
gdb/testsuite/gdb.reverse/rerun-prec.c
Normal file
21
gdb/testsuite/gdb.reverse/rerun-prec.c
Normal file
|
@ -0,0 +1,21 @@
|
|||
/* This testcase is part of GDB, the GNU debugger.
|
||||
|
||||
Copyright 2014 Free Software Foundation, Inc.
|
||||
|
||||
This program is free software; you can redistribute it and/or modify
|
||||
it under the terms of the GNU General Public License as published by
|
||||
the Free Software Foundation; either version 3 of the License, or
|
||||
(at your option) any later version.
|
||||
|
||||
This program is distributed in the hope that it will be useful,
|
||||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
GNU General Public License for more details.
|
||||
|
||||
You should have received a copy of the GNU General Public License
|
||||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||||
|
||||
int main (int argc, char **argv)
|
||||
{
|
||||
return 0;
|
||||
}
|
35
gdb/testsuite/gdb.reverse/rerun-prec.exp
Normal file
35
gdb/testsuite/gdb.reverse/rerun-prec.exp
Normal file
|
@ -0,0 +1,35 @@
|
|||
# Copyright 2014 Free Software Foundation, Inc.
|
||||
|
||||
# This program is free software; you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
# the Free Software Foundation; either version 3 of the License, or
|
||||
# (at your option) any later version.
|
||||
#
|
||||
# This program is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||||
|
||||
if {![supports_reverse] || ![supports_process_record]} {
|
||||
return
|
||||
}
|
||||
|
||||
standard_testfile
|
||||
|
||||
if {[prepare_for_testing $testfile.exp $testfile [list $srcfile]]} {
|
||||
return -1
|
||||
}
|
||||
|
||||
# The bug is a regression in the sequence "run; record; run".
|
||||
runto main
|
||||
gdb_test_no_output "record" "Turn on process record"
|
||||
|
||||
gdb_run_cmd
|
||||
gdb_test_multiple "" "restarting inferior" {
|
||||
-re "Breakpoint .*${gdb_prompt} " {
|
||||
pass "restarting inferior"
|
||||
}
|
||||
}
|
Loading…
Add table
Reference in a new issue