FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use bool in bpstat

Browse source 
This changes bpstat to use 'bool' rather than 'char', and updates the
uses.
This commit is contained in:
Tom Tromey 2022-11-11 14:50:50 -07:00
parent dad6b350f9
commit 4ec2227afb
6 changed files with 31 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

38
gdb/breakpoint.c
View file

@ -5253,7 +5253,7 @@ bpstat_check_location (const struct bp_location *bl,
}
/* Determine if the watched values have actually changed, and we
should stop. If not, set BS->stop to 0. */
should stop. If not, set BS->stop to false. */
static void
bpstat_check_watchpoint (bpstat *bs)
@ -5320,7 +5320,7 @@ bpstat_check_watchpoint (bpstat *bs)
break;
case WP_IGNORE:
bs->print_it = print_it_noop;
bs->stop = 0;
bs->stop = false;
break;
case WP_VALUE_CHANGED:
if (b->type == bp_read_watchpoint)
@ -5387,7 +5387,7 @@ bpstat_check_watchpoint (bpstat *bs)
updated it, so this trap must be for a write.
Ignore it. */
bs->print_it = print_it_noop;
bs->stop = 0;
bs->stop = false;
}
}
break;
@ -5398,7 +5398,7 @@ bpstat_check_watchpoint (bpstat *bs)
/* Don't stop: write watchpoints shouldn't fire if
the value hasn't changed. */
bs->print_it = print_it_noop;
bs->stop = 0;
bs->stop = false;
}
/* Stop. */
break;
@ -5414,7 +5414,7 @@ bpstat_check_watchpoint (bpstat *bs)
watchpoint triggered after all. So don't print
anything for this watchpoint. */
bs->print_it = print_it_noop;
bs->stop = 0;
bs->stop = false;
}
}
}
@ -5457,7 +5457,7 @@ bpstat_check_breakpoint_conditions (bpstat *bs, thread_info *thread)
infrun_debug_printf ("incorrect frame %s not %s, not stopping",
get_stack_frame_id (get_current_frame ()).to_string ().c_str (),
b->frame_id.to_string ().c_str ());
bs->stop = 0;
bs->stop = false;
return;
}
@ -5468,7 +5468,7 @@ bpstat_check_breakpoint_conditions (bpstat *bs, thread_info *thread)
|| (b->task != 0 && b->task != ada_get_task_number (thread)))
{
infrun_debug_printf ("incorrect thread or task, not stopping");
bs->stop = 0;
bs->stop = false;
return;
}
@ -5558,7 +5558,7 @@ bpstat_check_breakpoint_conditions (bpstat *bs, thread_info *thread)
if (cond != nullptr && !condition_result)
{
infrun_debug_printf ("condition_result = false, not stopping");
bs->stop = 0;
bs->stop = false;
return;
}
else if (b->ignore_count > 0)
@ -5566,7 +5566,7 @@ bpstat_check_breakpoint_conditions (bpstat *bs, thread_info *thread)
infrun_debug_printf ("ignore count %d, not stopping",
b->ignore_count);
b->ignore_count--;
bs->stop = 0;
bs->stop = false;
/* Increase the hit count even though we don't stop. */
++(b->hit_count);
gdb::observers::breakpoint_modified.notify (b);
@ -5629,8 +5629,8 @@ build_bpstat_chain (const address_space *aspace, CORE_ADDR bp_addr,
/* Assume we stop. Should we find a watchpoint that is not
actually triggered, or if the condition of the breakpoint
evaluates as false, we'll reset 'stop' to 0. */
bs->stop = 1;
bs->print = 1;
bs->stop = true;
bs->print = true;
/* If this is a scope breakpoint, mark the associated
watchpoint as triggered so that we will handle the
@ -5656,8 +5656,8 @@ build_bpstat_chain (const address_space *aspace, CORE_ADDR bp_addr,
{
bpstat *bs = new bpstat (loc, &bs_link);
/* For hits of moribund locations, we should just proceed. */
bs->stop = 0;
bs->print = 0;
bs->stop = false;
bs->print = false;
bs->print_it = print_it_noop;
}
}
@ -5734,11 +5734,11 @@ bpstat_stop_status (const address_space *aspace,
}
gdb::observers::breakpoint_modified.notify (b);
if (b->silent)
bs->print = 0;
bs->print = false;
bs->commands = b->commands;
if (command_line_is_silent (bs->commands
? bs->commands.get () : NULL))
bs->print = 0;
bs->print = false;
b->after_condition_true (bs);
}
@ -11882,11 +11882,11 @@ internal_breakpoint::check_status (bpstat *bs)
events. This allows the user to get control and place
breakpoints in initializer routines for dynamically loaded
objects (among other things). */
bs->stop = stop_on_solib_events;
bs->print = stop_on_solib_events;
bs->stop = stop_on_solib_events != 0;
bs->print = stop_on_solib_events != 0;
}
else
bs->stop = 0;
bs->stop = false;
}
enum print_stop_action
@ -12133,7 +12133,7 @@ dprintf_breakpoint::after_condition_true (struct bpstat *bs)
/* dprintf's never cause a stop. This wasn't set in the
check_status hook instead because that would make the dprintf's
condition not be evaluated. */
bs->stop = 0;
bs->stop = false;
/* Run the command list here. Take ownership of it instead of
copying. We never want these commands to run later in