FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove "noisy" parameter from clear_complaints

Browse source 
After the previous patch, the "noisy" parameter to clear_complaints is
no longer used, so this patch removes it.

gdb/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* complaints.c (clear_complaints): Remove "noisy" parameter.
	* complaints.h (clear_complaints): Update.
	* symfile.c (syms_from_objfile_1, finish_new_objfile)
	(reread_symbols): Update.

gdb/testsuite/ChangeLog
2018-05-23  Tom Tromey  <tom@tromey.com>

	* gdb.gdb/complaints.exp (test_empty_complaints): Update.
This commit is contained in:
Tom Tromey 2018-05-16 22:27:50 -06:00
parent 43ba33c768
commit 4e9668d0d1
6 changed files with 23 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

7
gdb/ChangeLog
View file

@ -1,3 +1,10 @@
2018-05-23 Tom Tromey <tom@tromey.com>
* complaints.c (clear_complaints): Remove "noisy" parameter.
* complaints.h (clear_complaints): Update.
* symfile.c (syms_from_objfile_1, finish_new_objfile)
(reread_symbols): Update.
2018-05-23 Tom Tromey <tom@tromey.com> 2018-05-23 Tom Tromey <tom@tromey.com>
* complaints.c (enum complaint_series): Remove FIRST_MESSAGE, * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,

6
gdb/complaints.c
View file

@ -220,12 +220,10 @@ complaint_internal (struct complaints **complaints, const char *fmt, ...)
incremented. If LESS_VERBOSE is 1, be less verbose about incremented. If LESS_VERBOSE is 1, be less verbose about
successive complaints, since the messages are appearing all successive complaints, since the messages are appearing all
together during a command that is reporting a contiguous block of together during a command that is reporting a contiguous block of
complaints (rather than being interleaved with other messages). If complaints (rather than being interleaved with other messages). */
noisy is 1, we are in a noisy command, and our caller will print
enough context for the user to figure it out. */
void void
clear_complaints (struct complaints **c, int less_verbose, int noisy) clear_complaints (struct complaints **c, int less_verbose)
{ {
struct complaints *complaints = get_complaints (c); struct complaints *complaints = get_complaints (c);
struct complain *p; struct complain *p;

2
gdb/complaints.h
View file

@ -56,7 +56,7 @@ extern void complaint_internal (struct complaints **complaints,
enough context for the user to figure it out. */ enough context for the user to figure it out. */
extern void clear_complaints (struct complaints **complaints, extern void clear_complaints (struct complaints **complaints,
int less_verbose, int noisy); int less_verbose);
#endif /* !defined (COMPLAINTS_H) */ #endif /* !defined (COMPLAINTS_H) */

8
gdb/symfile.c
View file

@ -986,7 +986,7 @@ syms_from_objfile_1 (struct objfile *objfile,
initial symbol reading for this file. */ initial symbol reading for this file. */
(*objfile->sf->sym_init) (objfile); (*objfile->sf->sym_init) (objfile);
clear_complaints (&symfile_complaints, 1, add_flags & SYMFILE_VERBOSE); clear_complaints (&symfile_complaints, 1);
(*objfile->sf->sym_offsets) (objfile, *addrs); (*objfile->sf->sym_offsets) (objfile, *addrs);
@ -1033,7 +1033,7 @@ finish_new_objfile (struct objfile *objfile, symfile_add_flags add_flags)
} }
/* We're done reading the symbol file; finish off complaints. */ /* We're done reading the symbol file; finish off complaints. */
clear_complaints (&symfile_complaints, 0, add_flags & SYMFILE_VERBOSE); clear_complaints (&symfile_complaints, 0);
} }
/* Process a symbol file, as either the main file or as a dynamically /* Process a symbol file, as either the main file or as a dynamically
@ -2457,7 +2457,7 @@ reread_symbols (void)
} }
(*objfile->sf->sym_init) (objfile); (*objfile->sf->sym_init) (objfile);
clear_complaints (&symfile_complaints, 1, 1); clear_complaints (&symfile_complaints, 1);
objfile->flags &= ~OBJF_PSYMTABS_READ; objfile->flags &= ~OBJF_PSYMTABS_READ;
@ -2487,7 +2487,7 @@ reread_symbols (void)
} }
/* We're done reading the symbol file; finish off complaints. */ /* We're done reading the symbol file; finish off complaints. */
clear_complaints (&symfile_complaints, 0, 1); clear_complaints (&symfile_complaints, 0);
/* Getting new symbols may change our opinion about what is /* Getting new symbols may change our opinion about what is
frameless. */ frameless. */

4
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,7 @@
2018-05-23 Tom Tromey <tom@tromey.com>
* gdb.gdb/complaints.exp (test_empty_complaints): Update.
2018-05-23 Tom Tromey <tom@tromey.com> 2018-05-23 Tom Tromey <tom@tromey.com>
* gdb.gdb/complaints.exp (test_serial_complaints): Remove. * gdb.gdb/complaints.exp (test_serial_complaints): Remove.

14
gdb/testsuite/gdb.gdb/complaints.exp
View file

@ -88,7 +88,7 @@ proc test_initial_complaints { } {
# For short complaints, all are the same # For short complaints, all are the same
proc test_short_complaints { } { proc test_short_complaints { } {
gdb_test_exact "call clear_complaints (&symfile_complaints, 1, 1)" "" "short start" gdb_test_exact "call clear_complaints (&symfile_complaints, 1)" "" "short start"
# Prime the system # Prime the system
test_complaint \ test_complaint \
@ -131,14 +131,10 @@ proc test_empty_complaint { cmd msg } {
proc test_empty_complaints { } { proc test_empty_complaints { } {
test_empty_complaint "call clear_complaints(&symfile_complaints,0,0)" \ test_empty_complaint "call clear_complaints(&symfile_complaints,0)" \
"empty non-verbose non-noisy clear" "empty non-verbose clear"
test_empty_complaint "call clear_complaints(&symfile_complaints,1,0)" \ test_empty_complaint "call clear_complaints(&symfile_complaints,1)" \
"empty verbose non-noisy clear" "empty verbose clear"
test_empty_complaint "call clear_complaints(&symfile_complaints,1,1)" \
"empty verbose noisy clear"
test_empty_complaint "call clear_complaints(&symfile_complaints,0,1)" \
"empty non-verbose noisy clear"
return 0 return 0
} }