FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb/

Browse source 
* varobj.c (varobj_create): Error if the specified frame was not found
	and it is needed.

gdb/testsuite/
	* gdb.mi/mi2-var-cmd.exp (create variable with invalid FRAME-ADDR): New.
This commit is contained in:
Jan Kratochvil 2009-08-27 06:33:25 +00:00
parent 573e8a1cd2
commit 4e22772d17
4 changed files with 22 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2009-08-27 Jan Kratochvil <jan.kratochvil@redhat.com>
* varobj.c (varobj_create): Error if the specified frame was not found
and it is needed.
2009-08-26 Michael Snyder <msnyder@vmware.com>
* i386-tdep.c (i386_process_record): Break out of prefix loop

4
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,7 @@
2009-08-27 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.mi/mi2-var-cmd.exp (create variable with invalid FRAME-ADDR): New.
2009-08-26 Michael Snyder <msnyder@vmware.com>
* gdb.base/i386-reverse.c: New file.

5
gdb/testsuite/gdb.mi/mi2-var-cmd.exp
View file

@ -126,6 +126,11 @@ mi_gdb_test "-var-create int * int" \
"&\"Attempt to use a type name as an expression.\\\\n\".*\\^error,msg=\"mi_cmd_var_create: unable to create variable object\"" \
"create int"
# The number 0 must be an invalid frame address and linteger a local variable.
mi_gdb_test "-var-create invalidframe 0 linteger" \
"\\^error,msg=\"Failed to find the specified frame\"" \
"create variable with invalid FRAME-ADDR"
##### #####
# #

9
gdb/varobj.c
View file

@ -565,8 +565,15 @@ varobj_create (char *objname,
we must select the appropriate frame before parsing
the expression, otherwise the value will not be current.
Since select_frame is so benign, just call it for all cases. */
if (innermost_block && fi != NULL)
if (innermost_block)
{
/* User could specify explicit FRAME-ADDR which was not found but
EXPRESSION is frame specific and we would not be able to evaluate
it correctly next time. With VALID_BLOCK set we must also set
FRAME and THREAD_ID. */
if (fi == NULL)
error (_("Failed to find the specified frame"));
var->root->frame = get_frame_id (fi);
var->root->thread_id = pid_to_thread_id (inferior_ptid);
old_fi = get_selected_frame (NULL);