FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb, python: do minor modernization in execute_gdb_command

Browse source 
Use nullptr instead of NULL and boolify two local variables in
execute_gdb_command.

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Tankut Baris Aktemur 2023-02-27 10:28:40 +01:00
parent 4dd74c176b
commit 4e08903f67
1 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
gdb/python/python.c
View file

@ -621,31 +621,32 @@ static PyObject *
execute_gdb_command (PyObject *self, PyObject *args, PyObject *kw)
{
const char *arg;
PyObject *from_tty_obj = NULL, *to_string_obj = NULL;
int from_tty, to_string;
static const char *keywords[] = { "command", "from_tty", "to_string", NULL };
PyObject *from_tty_obj = nullptr;
PyObject *to_string_obj = nullptr;
static const char *keywords[] = { "command", "from_tty", "to_string",
nullptr };
if (!gdb_PyArg_ParseTupleAndKeywords (args, kw, "s|O!O!", keywords, &arg,
&PyBool_Type, &from_tty_obj,
&PyBool_Type, &to_string_obj))
return NULL;
return nullptr;
from_tty = 0;
if (from_tty_obj)
bool from_tty = false;
if (from_tty_obj != nullptr)
{
int cmp = PyObject_IsTrue (from_tty_obj);
if (cmp < 0)
return NULL;
from_tty = cmp;
return nullptr;
from_tty = (cmp != 0);
}
to_string = 0;
if (to_string_obj)
bool to_string = false;
if (to_string_obj != nullptr)
{
int cmp = PyObject_IsTrue (to_string_obj);
if (cmp < 0)
return NULL;
to_string = cmp;
return nullptr;
to_string = (cmp != 0);
}
std::string to_string_res;