FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* inflow.c (child_terminal_inferior): Add comment.

Browse source 
(child_terminal_ours_for_output): Add comment.
	(child_terminal_ours): Add comment.
	* linux-nat.c (linux_nat_terminal_inferior): Add comment.
	(linux_nat_terminal_ours): Add comment.
This commit is contained in:
Doug Evans 2014-07-31 11:48:24 -07:00
parent 462f517e50
commit 4d4ca2a15d
3 changed files with 33 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
gdb/ChangeLog
View file

@ -1,3 +1,11 @@
2014-07-31 Doug Evans <dje@google.com>
* inflow.c (child_terminal_inferior): Add comment.
(child_terminal_ours_for_output): Add comment.
(child_terminal_ours): Add comment.
* linux-nat.c (linux_nat_terminal_inferior): Add comment.
(linux_nat_terminal_ours): Add comment.
2014-07-31 Gary Benson <gbenson@redhat.com> 2014-07-31 Gary Benson <gbenson@redhat.com>
* common/btrace-common.h: Do not include defs.h or server.h. * common/btrace-common.h: Do not include defs.h or server.h.

17
gdb/inflow.c
View file

@ -267,7 +267,11 @@ child_terminal_init (struct target_ops *self)
} }
/* Put the inferior's terminal settings into effect. /* Put the inferior's terminal settings into effect.
This is preparation for starting or resuming the inferior. */ This is preparation for starting or resuming the inferior.
N.B. Targets that want to use this with async support must build that
support on top of this (e.g., the caller still needs to remove stdin
from the event loop). E.g., see linux_nat_terminal_inferior. */
void void
child_terminal_inferior (struct target_ops *self) child_terminal_inferior (struct target_ops *self)
@ -348,7 +352,10 @@ child_terminal_inferior (struct target_ops *self)
so that no input is discarded. so that no input is discarded.
After doing this, either terminal_ours or terminal_inferior After doing this, either terminal_ours or terminal_inferior
should be called to get back to a normal state of affairs. */ should be called to get back to a normal state of affairs.
N.B. The implementation is (currently) no different than
child_terminal_ours. See child_terminal_ours_1. */
void void
child_terminal_ours_for_output (struct target_ops *self) child_terminal_ours_for_output (struct target_ops *self)
@ -358,7 +365,11 @@ child_terminal_ours_for_output (struct target_ops *self)
/* Put our terminal settings into effect. /* Put our terminal settings into effect.
First record the inferior's terminal settings First record the inferior's terminal settings
so they can be restored properly later. */ so they can be restored properly later.
N.B. Targets that want to use this with async support must build that
support on top of this (e.g., the caller still needs to add stdin to the
event loop). E.g., see linux_nat_terminal_ours. */
void void
child_terminal_ours (struct target_ops *self) child_terminal_ours (struct target_ops *self)

13
gdb/linux-nat.c
View file

@ -4595,7 +4595,9 @@ linux_nat_supports_disable_randomization (struct target_ops *self)
static int async_terminal_is_ours = 1; static int async_terminal_is_ours = 1;
/* target_terminal_inferior implementation. */ /* target_terminal_inferior implementation.
This is a wrapper around child_terminal_inferior to add async support. */
static void static void
linux_nat_terminal_inferior (struct target_ops *self) linux_nat_terminal_inferior (struct target_ops *self)
@ -4618,7 +4620,14 @@ linux_nat_terminal_inferior (struct target_ops *self)
set_sigint_trap (); set_sigint_trap ();
} }
/* target_terminal_ours implementation. */ /* target_terminal_ours implementation.
This is a wrapper around child_terminal_ours to add async support (and
implement the target_terminal_ours vs target_terminal_ours_for_output
distinction). child_terminal_ours is currently no different than
child_terminal_ours_for_output.
We leave target_terminal_ours_for_output alone, leaving it to
child_terminal_ours_for_output. */
static void static void
linux_nat_terminal_ours (struct target_ops *self) linux_nat_terminal_ours (struct target_ops *self)