FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[gdb/testsuite] Fix gdb.dwarf2/gdb-add-index-symlink.exp

Browse source 
The test-case gdb.dwarf2/gdb-add-index-symlink.exp interpretes a failure to
add an index as a failure to add an index for a symlink:
...
if { [ensure_gdb_index $symlink] == -1 } {
    fail "Unable to call gdb-add-index with a symlink to a symfile"
    return -1
}
...

However, it's possible that the gdb-add-index also fails with a regular
file.  Add a check for that situation.

Tested on x86_64-linux.
This commit is contained in:
Tom de Vries 2021-10-11 12:21:00 +02:00
parent 4f69f0a21e
commit 47265957ad
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp
View file

@ -22,6 +22,19 @@ if {![dwarf2_support]} {
standard_testfile main.c
# First check whether we can actually handle the non-symlink case.
with_test_prefix non-symlink {
if { [prepare_for_testing "failed to prepare" "${testfile}" \
[list ${srcfile}]] } {
return -1
}
if { [ensure_gdb_index $binfile] == -1 } {
return -1
}
}
# Regenerate exec without index.
if { [prepare_for_testing "failed to prepare" "${testfile}" \
[list ${srcfile}]] } {
return -1