FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb/fortran: Remove some dead code from the parser

Browse source 
The Fortran parser contains some code that looks like it was probably
inherited from the C/C++ parser as it checks to see if the current
language is C++, which should never be true when we're in the Fortran
parser.

gdb/ChangeLog:

	* f-exp.y (yylex): Remove is_a_field_of_this local variable, and
	all uses as this was never set to anything but a zero value.
This commit is contained in:
Andrew Burgess 2019-08-22 10:07:00 +01:00
parent 652afeef24
commit 43771869e5
2 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
* f-exp.y (yylex): Remove is_a_field_of_this local variable, and
all uses as this was never set to anything but a zero value.
2019-08-21 Bogdan Harjoc <harjoc@gmail.com> 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
* cli/cli-cmds.c (with_command_1): Error out if no arguments. * cli/cli-cmds.c (with_command_1): Error out if no arguments.

14
gdb/f-exp.y
View file

@ -1275,7 +1275,6 @@ yylex (void)
{ {
std::string tmp = copy_name (yylval.sval); std::string tmp = copy_name (yylval.sval);
struct block_symbol result; struct block_symbol result;
struct field_of_this_result is_a_field_of_this;
enum domain_enum_tag lookup_domains[] = enum domain_enum_tag lookup_domains[] =
{ {
STRUCT_DOMAIN, STRUCT_DOMAIN,
@ -1286,15 +1285,8 @@ yylex (void)
for (int i = 0; i < ARRAY_SIZE (lookup_domains); ++i) for (int i = 0; i < ARRAY_SIZE (lookup_domains); ++i)
{ {
/* Initialize this in case we *don't* use it in this call; that
way we can refer to it unconditionally below. */
memset (&is_a_field_of_this, 0, sizeof (is_a_field_of_this));
result = lookup_symbol (tmp.c_str (), pstate->expression_context_block, result = lookup_symbol (tmp.c_str (), pstate->expression_context_block,
lookup_domains[i], lookup_domains[i], NULL);
pstate->language ()->la_language
== language_cplus
? &is_a_field_of_this : NULL);
if (result.symbol && SYMBOL_CLASS (result.symbol) == LOC_TYPEDEF) if (result.symbol && SYMBOL_CLASS (result.symbol) == LOC_TYPEDEF)
{ {
yylval.tsym.type = SYMBOL_TYPE (result.symbol); yylval.tsym.type = SYMBOL_TYPE (result.symbol);
@ -1323,14 +1315,14 @@ yylex (void)
if (hextype == INT) if (hextype == INT)
{ {
yylval.ssym.sym = result; yylval.ssym.sym = result;
yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL; yylval.ssym.is_a_field_of_this = false;
return NAME_OR_INT; return NAME_OR_INT;
} }
} }
/* Any other kind of symbol */ /* Any other kind of symbol */
yylval.ssym.sym = result; yylval.ssym.sym = result;
yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL; yylval.ssym.is_a_field_of_this = false;
return NAME; return NAME;
} }
} }