FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clear entire "location" in value constructor

Browse source 
My recent change to allocate values with "new" may have introduced a
small bug.  In particular, the previous code allocated with XCNEW, but
the new code only clears a part of the "location" field in the
constructor.  I didn't try very hard to actually trigger a bug here,
the problem remains theoretical.

This patch just arranges to initialize the entire location.

Regression tested by the buildbot.

2018-05-25  Tom Tromey  <tom@tromey.com>

	* value.c (value::location): Initialize.
This commit is contained in:
Tom Tromey 2018-04-10 08:24:43 -06:00
parent bf259e253f
commit 41a883c8ed
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
gdb/value.c
View file

@ -180,7 +180,6 @@ struct value
type (type_),
enclosing_type (type_)
{
location.address = 0;
}
~value ()
@ -262,7 +261,7 @@ struct value
/* Closure for those functions to use. */
void *closure;
} computed;
} location;
} location {};
/* Describes offset of a value within lval of a structure in target
addressable memory units. Note also the member embedded_offset