FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Let commands free "name"

Browse source 
This adds a "name_allocated" field to cmd_list_element, so that
commands can own their "name" when necessary.  Then, this changes a
few spots in gdb that currently free the name by hand to instead use
this facility.

gdb/ChangeLog
2019-11-26  Tom Tromey  <tom@tromey.com>

	* python/py-function.c (fnpy_init): Update.
	* value.h (add_internal_function): Adjust declaration.
	* value.c (function_destroyer): Remove.
	(do_add_internal_function): Don't set destroyer or copy name.
	(add_internal_function): Take unique_xmalloc_ptr<char> for name.
	Set name_allocated.
	* python/py-cmd.c (cmdpy_destroyer): Don't free "name".
	(cmdpy_init): Set name_allocated.
	* cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
	member.
	(~cmd_list_element): Free "name" if needed.

Change-Id: Ie1435cea5bbf4bd92056125f112917c607cbb761
This commit is contained in:
Tom Tromey 2019-11-15 16:56:20 -07:00
parent 1a6d41c643
commit 3ea16160a6
6 changed files with 32 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

7
gdb/cli/cli-decode.h
View file

@ -55,6 +55,7 @@ struct cmd_list_element
deprecated_warn_user (0),
malloced_replacement (0),
doc_allocated (0),
name_allocated (0),
hook_in (0),
allow_unknown (0),
abbrev_flag (0),
@ -69,6 +70,8 @@ struct cmd_list_element
{
if (doc && doc_allocated)
xfree ((char *) doc);
if (name_allocated)
xfree ((char *) name);
}
DISABLE_COPY_AND_ASSIGN (cmd_list_element);
@ -109,6 +112,10 @@ struct cmd_list_element
unsigned int doc_allocated : 1;
/* Set if the name field should be xfree'd. */
unsigned int name_allocated : 1;
/* Flag that specifies if this command is already running its hook. */
/* Prevents the possibility of hook recursion. */
unsigned int hook_in : 1;