FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb/nat: Use procfs(5) indexes in linux_common_core_of_thread

Browse source 
The code and comment reference stat fields by made-up indexes.  The
procfs(5) man page, which describes the /proc/PID/stat file, has a numbered
list of these fields so it's more convenient to use those numbers instead.

This is currently an implementation detail inside the function so it's
not really relevant with the code as-is, but a future patch will do some
refactoring which will make the index more prominent.

Therefore, make this change in a separate patch so that it's simpler to
review.

Reviewed-By: Luis Machado <luis.machado@arm.com>
Approved-By: Pedro Alves <pedro@palves.net>
This commit is contained in:
Thiago Jung Bauermann 2024-03-18 19:28:50 -03:00
parent a75d04db22
commit 3de4256ca3
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gdb/nat/linux-osdata.c
View file

@ -52,6 +52,10 @@ typedef long long TIME_T;
#define MAX_PID_T_STRLEN (sizeof ("-9223372036854775808") - 1)
/* Index of fields of interest in /proc/PID/stat, from procfs(5) man page. */
#define LINUX_PROC_STAT_STATE 3
#define LINUX_PROC_STAT_PROCESSOR 39
/* Returns the CPU core that thread PTID is currently running on. */
/* Compute and return the processor core of a given thread. */
@ -74,10 +78,9 @@ linux_common_core_of_thread (ptid_t ptid)
if (pos == std::string::npos)
return -1;
/* If the first field after program name has index 0, then core number is
the field with index 36 (so, the 37th). There's no constant for that
anywhere. */
for (int i = 0; i < 37; ++i)
/* The first field after program name is LINUX_PROC_STAT_STATE, and we are
interested in field LINUX_PROC_STAT_PROCESSOR. */
for (int i = LINUX_PROC_STAT_STATE; i <= LINUX_PROC_STAT_PROCESSOR; ++i)
{
/* Find separator. */
pos = content->find_first_of (' ', pos);