FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Eliminate agent_expr_p; VEC -> std::vector in struct bp_target_info

Browse source 
After the previous patch, we end up with these two types with quite
similar, and potentially confusing names:

  typedef gdb::unique_ptr<agent_expr> agent_expr_up;

  /* Pointer to an agent_expr structure.  */
  typedef struct agent_expr *agent_expr_p;

The latter is only necessary to put agent_expr pointers in VECs.  So
just eliminate it and use std::vector instead.

gdb/ChangeLog:
2016-11-08  Pedro Alves  <palves@redhat.com>

	* ax.h (agent_expr_p): Delete.
	(DEF_VEC_P (agent_expr_p)): Delete.
	* breakpoint.c (build_target_condition_list)
	(build_target_command_list): Adjust to use of std::vector.
	(bp_location_dtor): Remove now unnecessary VEC_free calls.
	* breakpoint.h: Include <vector>.
	(struct bp_target_info) <conditions, tcommands>: Now
	std::vector's.
	* remote.c (remote_add_target_side_condition): bp_tgt->conditions
	is now a std::vector; adjust.
	(remote_add_target_side_commands, remote_insert_breakpoint):
	bp_tgt->tcommands is now a std::vector; adjust.
This commit is contained in:
Pedro Alves 2016-11-08 15:26:47 +00:00
parent 833177a4a5
commit 3cde5c42d1
5 changed files with 46 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

13
gdb/breakpoint.h
View file

@ -26,6 +26,7 @@
#include "command.h"
#include "break-common.h"
#include "probe.h"
#include <vector>
struct value;
struct block;
@ -264,13 +265,13 @@ struct bp_target_info
packets. */
int kind;
/* Vector of conditions the target should evaluate if it supports target-side
breakpoint conditions. */
VEC(agent_expr_p) *conditions;
/* Conditions the target should evaluate if it supports target-side
breakpoint conditions. These are non-owning pointers. */
std::vector<agent_expr *> conditions;
/* Vector of commands the target should evaluate if it supports
target-side breakpoint commands. */
VEC(agent_expr_p) *tcommands;
/* Commands the target should evaluate if it supports target-side
breakpoint commands. These are non-owning pointers. */
std::vector<agent_expr *> tcommands;
/* Flag that is true if the breakpoint should be left in place even
when GDB is not connected. */