FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

infinite recursion with ada_check_typedef

Browse source 
When trying to resolve an incomplete type, if there is no complete
version of that type available, GDB can go in an infinite loop.

This is because ada_check_typedef makes a recursive call to itself,
in an attempt to make sure that the returned type is never a typedef.
However, when no complete type is found, the current logic causes us
to keep going indefinitely through the same path...

This patch fixes the problem by performing the recursive call to
ada_check_typedef only when a TYPE_CODE_TYPDEF layer needs to be
stripped.

gdb/ChangeLog:

        * ada-lang.c (ada_check_typedef): Call ada_check_typedef only
        if type1 is a typedef.
This commit is contained in:
Joel Brobecker 2010-11-23 01:03:54 +00:00
parent df30368de1
commit 3a867c2212
2 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2010-11-22 Joel Brobecker <brobecker@adacore.com>
* ada-lang.c (ada_check_typedef): Call ada_check_typedef only
if type1 is a typedef.
2010-11-22 Joel Brobecker <brobecker@adacore.com>
* ada-lang.h (ADA_KNOWN_AUXILIARY_FUNCTION_NAME_PATTERNS): Add

10
gdb/ada-lang.c
View file

@ -7756,10 +7756,12 @@ ada_check_typedef (struct type *type)
/* TYPE1 might itself be a TYPE_CODE_TYPEDEF (this can happen with
stubs pointing to arrays, as we don't create symbols for array
types, only for the typedef-to-array types). This is why
we process TYPE1 with ada_check_typedef before returning
the result. */
return ada_check_typedef (type1);
types, only for the typedef-to-array types). If that's the case,
strip the typedef layer. */
if (TYPE_CODE (type1) == TYPE_CODE_TYPEDEF)
type1 = ada_check_typedef (type1);
return type1;
}
}