FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Report Python errors coming from gdb.post_event

Browse source 
PR python/14062 points out that errors coming from the gdb.post_event
callback are not reported.  This can make it hard to understand why
your Python code in gdb isn't working.

Because users have control over whether exceptions are printed at all,
it seems good to simply have post_event report errors in the usual
way.

2018-09-23  Tom Tromey  <tom@tromey.com>

	PR python/14062:
	* python/python.c (gdbpy_run_events): Do not ignore exceptions.

gdb/testsuite/ChangeLog
2018-09-23  Tom Tromey  <tom@tromey.com>

	PR python/14062:
	* gdb.python/python.exp: Add test for post_event error.
This commit is contained in:
Tom Tromey 2018-09-15 00:07:32 -06:00
parent f5769a2c69
commit 39a24317ac
4 changed files with 23 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
gdb/python/python.c
View file

@ -987,10 +987,9 @@ gdbpy_run_events (int error, gdb_client_data client_data)
if (gdbpy_event_list == NULL)
gdbpy_event_list_end = &gdbpy_event_list;
/* Ignore errors. */
gdbpy_ref<> call_result (PyObject_CallObject (item->event, NULL));
if (call_result == NULL)
PyErr_Clear ();
gdbpy_print_stack ();
Py_DECREF (item->event);
xfree (item);