Add timestamps to "maint time" output

Currently "maint time" will print the amount of time a command took.
Sometimes, though, it's useful to have a timestamp as well -- for
example if one is correlating a gdb log with some other log.

This patch adds a timestamp to the start and end of each command when
this setting is in effect.

This also removes a "//" comment and changes scoped_command_stats to
use DISABLE_COPY_AND_ASSIGN; two minor things I noticed while working
on the patch.

Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-06-06  Tom Tromey  <tromey@adacore.com>

	* maint.h (class scoped_command_stats): Use
	DISABLE_COPY_AND_ASSIGN.
	<print_time>: New method.
	* maint.c (scoped_command_stats, ~scoped_command_stats): Call
	print_time.
	(scoped_command_stats::print_time): New method.

gdb/testsuite/ChangeLog
2019-06-06  Tom Tromey  <tromey@adacore.com>

	* gdb.base/maint.exp: Expect command started/finished output.
This commit is contained in:
Tom Tromey 2019-04-11 11:26:02 -06:00
parent 237df8fe18
commit 3847a7bfbf
5 changed files with 47 additions and 5 deletions

View file

@ -38,9 +38,10 @@ class scoped_command_stats
private:
// No need for these. They are intentionally not defined anywhere.
scoped_command_stats &operator= (const scoped_command_stats &);
scoped_command_stats (const scoped_command_stats &);
DISABLE_COPY_AND_ASSIGN (scoped_command_stats);
/* Print the time, along with a string. */
void print_time (const char *msg);
/* Zero if the saved time is from the beginning of GDB execution.
One if from the beginning of an individual command execution. */