FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use unique_xmalloc_ptr<char> when demangling

Browse source 
I noticed that some methods in language_defn could use
unique_xmalloc_ptr<char> rather than a plain 'char *'.  This patch
implements this change, fixing up the fallout and changing
gdb_demangle to also return this type.  In one spot, std::string is
used to simplify some related code, and in another, an auto_obstack is
used to avoid manual management.

Regression tested on x86-64 Fedora 34.
This commit is contained in:
Tom Tromey 2021-10-04 08:44:22 -06:00
parent e133de4984
commit 3456e70c9d
23 changed files with 118 additions and 136 deletions
Download patch file Download diff file Expand all files Collapse all files

16
gdb/ada-lang.c
View file

@ -1324,12 +1324,6 @@ ada_decode_symbol (const struct general_symbol_info *arg)
return *resultp;
}
static char *
ada_la_decode (const char *encoded, int options)
{
return xstrdup (ada_decode (encoded).c_str ());
}
/* Arrays */
@ -13116,8 +13110,9 @@ public:
}
/* See language.h. */
bool sniff_from_mangled_name (const char *mangled,
char **out) const override
bool sniff_from_mangled_name
(const char *mangled,
gdb::unique_xmalloc_ptr<char> *out) const override
{
std::string demangled = ada_decode (mangled);
@ -13155,9 +13150,10 @@ public:
/* See language.h. */
char *demangle_symbol (const char *mangled, int options) const override
gdb::unique_xmalloc_ptr<char> demangle_symbol (const char *mangled,
int options) const override
{
return ada_la_decode (mangled, options);
return make_unique_xstrdup (ada_decode (mangled).c_str ());
}
/* See language.h. */